From: David Howells <dhowells@redhat.com>
To: Shreenidhi Shedi <yesshedi@gmail.com>
Cc: dhowells@redhat.com, dwmw2@infradead.org,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
sshedi@vmware.com
Subject: Re: [ PATCH v4 6/6] sign-file: improve help message
Date: Tue, 14 Mar 2023 16:20:10 +0000 [thread overview]
Message-ID: <3755170.1678810810@warthog.procyon.org.uk> (raw)
In-Reply-To: <20230221170804.3267242-6-sshedi@vmware.com>
Shreenidhi Shedi <yesshedi@gmail.com> wrote:
> + exit(retval);
Should be "exit(2)".
> + fprintf(stderr, "\nExamples:\n");
> +
> + fprintf(stderr, "\nRegular signing:\n");
You need to distinguish the two lines as they both look like headings when one
is actually a subheading of the other.
> + fprintf(stderr, "scripts/sign-file -a sha512 -p certs/signing_key.pem ");
> + fprintf(stderr, "-x certs/signing_key.x509 <module>\n");
David
next prev parent reply other threads:[~2023-03-14 16:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 17:07 [ PATCH v4 1/6] sign-file: refactor argument parsing logic Shreenidhi Shedi
2023-02-21 17:08 ` [ PATCH v4 2/6] sign-file: move file signing logic to its own function Shreenidhi Shedi
2023-03-14 16:10 ` David Howells
2023-02-21 17:08 ` [ PATCH v4 3/6] sign-file: add support sign modules in bulk Shreenidhi Shedi
2023-03-14 16:13 ` David Howells
2023-02-21 17:08 ` [ PATCH v4 4/6] sign-file: cosmetic fix Shreenidhi Shedi
2023-03-14 16:14 ` David Howells
2023-02-21 17:08 ` [ PATCH v4 5/6] sign-file: use const with a global string constant Shreenidhi Shedi
2023-03-14 16:15 ` David Howells
2023-02-21 17:08 ` [ PATCH v4 6/6] sign-file: improve help message Shreenidhi Shedi
2023-03-14 16:20 ` David Howells [this message]
2023-02-21 17:18 ` [ PATCH v4 1/6] sign-file: refactor argument parsing logic Greg KH
2023-03-14 16:02 ` David Howells
2023-03-14 16:21 ` David Howells
2023-03-20 15:47 ` Shreenidhi Shedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3755170.1678810810@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshedi@vmware.com \
--cc=yesshedi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox