From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751707AbcFUJdf (ORCPT ); Tue, 21 Jun 2016 05:33:35 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59572 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751638AbcFUJdb (ORCPT ); Tue, 21 Jun 2016 05:33:31 -0400 From: Arnd Bergmann To: thloh@altera.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, peppe.cavallaro@st.com, alexandre.torgue@st.com, davem@davemloft.net, preid@electromag.com.au, dinguyen@opensource.altera.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, thloh85@gmail.com, cnphoon@altera.com Subject: Re: [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga Date: Tue, 21 Jun 2016 11:34:49 +0200 Message-ID: <3759495.N5GR8CgQvA@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1466498771-18971-1-git-send-email-thloh@altera.com> References: <1466498771-18971-1-git-send-email-thloh@altera.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:0imIznbl2DkJOj1nuv/I3UtTiBaPiwiCY84oWb7eX7VCx4eBM1t fEUOvFJUsdH5ayaPIu7KVaIyK4Ybyb24ZZ+9FHXnevAgVguvGgzjqQtpOgtAEY+f/IozHYY WCqv8qaA102mbtx7muzXkEJy0FFQVancEOULlpSighWIYAxZWqpFk8BXfwwgvhXH3u3kCY+ 86MnXA0BBN8ypHNbgS0qQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:7lQExFV51V0=:GOpv3NmLGo1y36VCvqAH0D qu64ualtelT6Gf1LuFfBSMER4qLU5Cbg6z0/tle+6VY6s5iApoHlwtURJb1D9505hvkveypcG KCdBBdqhg1yPdlnM+Ku6c98XQVxdTbQLxkDM6lk6+uwHHRX9IoPh9A+ylT84Dj7c2Wfp2wdzX ToxGB2JntCEtIHzKYR5Anl6Zl8qBVHiufrgwDVKWestLbCLgB0Hbx3Adlb/do9UFNr365K/Op LaTq/30I/BGJjqZgm60gkDLp5pg4JBd4wrTjxhOebHkBg50Xxe3zfkENQ4fiCJPlE03iOS0/s jZvAcWUvH+3gbcGR+c5LiZJwxT5dtGG97JcnU7GQIPCcyArQ9aRbMaGYnqhxeJWlsYPUec0xF GFgYMsvGeqG2rHiUfXs3vFNZEUZ5BLOAEpi8sC8T7HOSQlZRpKJRlwOrmiFGt3Y6l3VMyg5f2 8yJBPW5rumBnTyufdRGkFV76d96D5XkzqxwdAflSlfok79gMgY42cvmUmXRqA47UzwIdRL0LG +/8rqCjcyjttsfKEfa3exRvERKp2FGG2sSUlO56zmYqPv3u3k7gSTBN3vYA71r7L+3khjfALZ 7ziK0deQo/Vl7Nw2BajZ1hAX+TUB4j9Z5XpHlrKgwn+xP2CkQdZPYinfsPyjuabU+Ez/vTjNs YV+sdVM0JCHcxmP8dysxohjBfKtWquhjbiPijb/SCPqXNOxNYFBNt6KNxyD/qh4gr1k6jsGdy OcCfYebQe/Vj5pmW Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, June 21, 2016 1:46:11 AM CEST thloh@altera.com wrote: > diff --git a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > index 72d82d6..dd10f2f 100644 > --- a/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > +++ b/Documentation/devicetree/bindings/net/socfpga-dwmac.txt > @@ -17,9 +17,26 @@ Required properties: > Optional properties: > altr,emac-splitter: Should be the phandle to the emac splitter soft IP node if > DWMAC controller is connected emac splitter. > +phy-mode: The phy mode the ethernet operates in > +altr,sgmii_to_sgmii_converter: phandle to the TSE SGMII converter > + Please use '-' instead of '_' in the property names. Can you explain in the patch description why you can't reference the converter using the normal "phy-handle" property and implement the converter as a phy driver? Arnd