From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756120AbcHXQOd (ORCPT <rfc822;w@1wt.eu>);
        Wed, 24 Aug 2016 12:14:33 -0400
Received: from mout.web.de ([212.227.15.14]:51244 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754800AbcHXQOb (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 24 Aug 2016 12:14:31 -0400
Subject: Re: wan-cosa: Use memdup_user() rather than duplicating its
 implementation
To: Jan Kasprzak <kas@fi.muni.cz>
References: <5d335025-5f52-d4b6-0b60-89a2fd354694@users.sourceforge.net>
 <20160824152154.GT10241@fi.muni.cz>
Cc: netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org, Julia Lawall <julia.lawall@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <375bce2b-6c19-902e-65ce-cccaedd2184e@users.sourceforge.net>
Date: Wed, 24 Aug 2016 18:14:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2
MIME-Version: 1.0
In-Reply-To: <20160824152154.GT10241@fi.muni.cz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
X-Provags-ID: V03:K0:ZKEG1sFEvZGpMoWV15mm7fNa0z58Xo/IOWuHGrMRDUwvxdQyymz
 LuLCbDFJlTc4GF5qncgzt5owkn6PtYaXs4ztlx1ZWP9xpOSb0KquQFBfSBRNNHf+2iSMG+p
 xn2BO4a1rJOpo2GaUCLIHAYCkvyia8Ks0Qx3pAgIU65ELPNMADVQDwkx0bi2YfmcYFjupki
 D5RF+HcUywai0aU89S93w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:8d2U9akFGvA=:5wQgsb4XtxZuXhAdcsGbjf
 H28qOZ7HjrME0de+unldB7dXlqNCNEz0JG0HhOEf4LaQJIXI62RQLVma671ylDgSPWltCtEPo
 k/R+9NRFuc7VV996OX6qEnTAAYJYOAZl3elfEw0McIFzAxGz/a3HzksiL4Nfd8L5x3PF/FzNs
 ewQ4ILxgvLMnHs9Gkaz8o6wc9nvVACelMVpcmZX1MTchYvFUR+cPMG5JsjDOuh0KXSCV6rLpF
 pZlAC5lz9L0tCeUCA1MZGNXm9J2SZqT7CZA6bXkL1Y6ME/LvaVIN/dUFglg1F7Vpjn6oVXnCq
 GhC/LBQ+bLJjZ6ap29PiVKQWz4fBh1jXOdCkvlCOFmAb8i7frtyHqyQLY3IHOYQknUjzj+rH4
 puLTqd0rboHLrK1FDdv3s/RFSNNkOyTrmdbBSk+BbT5Ey/TdGOoMNjvLuFZ5Iks382E3Y99bG
 ltlc2BfZSP/xtSjediXqo1E7jcTceJ5P0zpaQXYmBW4CW4N1DAoSELIhAraZz7Kp/XvXLpf4R
 wcW9DEFGS7Bc39cxf/K2aotUZSSkkkiM3HsNW1Ru/rfLdVaeuBfsnEh9UHCwEf7RGYZBwRufJ
 +WB0Bp/Stcxp4PS5dgweujgAi+H9JbOy7lDzF9zchTKKaFLrjV/1lahOG+qLcAS6Mk/spv2Yh
 ntorjO31sVWlrU+ZGQkSoUpbKaiERxTwWbjUqJZ5MlFBFe6bYCQroux2bUist0WBvRtThyl87
 VA+xoydi9ik6we1PSnxypJiIaUZ+zFEnTZj3sUK1fRqjjJzav4wtk7+NrF3rUUwtzn1eup64X
 tNiYTzW
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> 	What about the GFP_DMA attribute, which your patch deletes?
> The buffer in question has to be ISA DMA-able.

Thanks for your constructive feedback.

Would you be interested in using a variant of the function "memdup_…"
with which the corresponding memory allocation option can be preserved?

Regards,
Markus