From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Dylan Yudaken <dylany@fb.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
Fernanda Ma'rouf <fernandafmr12@gnuweeb.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>
Subject: Re: Linux 5.19-rc7 liburing test `poll-mshot-overflow.t` and `read-write.t` fail
Date: Thu, 21 Jul 2022 20:08:19 +0700 [thread overview]
Message-ID: <3761ef37-85fc-de81-b211-39eaf3fe2362@gnuweeb.org> (raw)
In-Reply-To: <e3987a2f55d154a7b217d86d805719043957db60.camel@fb.com>
On 7/21/22 7:05 PM, Dylan Yudaken wrote:
> It seems to be a problem with blocking reads, buffer select and READV.
> My guess is that ext4/xfs are not blocking.
>
> in b66e65f41426 ("io_uring: never call io_buffer_select() for a buffer
> re-select"), this line was added in __io_iov_buffer_select
>
> - iov[0].iov_len = len;
> + req->rw.len = iov[0].iov_len = len;
>
> Basically stashing the buffer length in rw.len. The problem is that the
> next time around that breaks at
>
> if (req->rw.len != 1)
> return -EINVAL;
>
>
> The below fixes it as an example, but it's not great. Maybe someone can
> figure out a better patch? Otherwise I can try tomorrow:
It's 8:05 PM from my end. I'll try to play with your patch after dinner
while waiting for others say something.
--
Ammar Faizi
next prev parent reply other threads:[~2022-07-21 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 23:21 Linux 5.19-rc7 liburing test `poll-mshot-overflow.t` and `read-write.t` fail Ammar Faizi
2022-07-21 9:48 ` Dylan Yudaken
2022-07-21 10:41 ` Ammar Faizi
2022-07-21 12:05 ` Dylan Yudaken
2022-07-21 13:08 ` Ammar Faizi [this message]
2022-07-21 13:14 ` Dylan Yudaken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3761ef37-85fc-de81-b211-39eaf3fe2362@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=dylany@fb.com \
--cc=fernandafmr12@gnuweeb.org \
--cc=gwml@vger.gnuweeb.org \
--cc=io-uring@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox