[PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

[PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

[Rajneesh Bhardwaj]

Ice Lake Neural Network Processor for deep learning inference a.k.a.
ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core
driver on it.

Cc: Darren Hart <dvhart@infradead.org>
Cc: Andy Shevchenko <andy@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
Link: https://lkml.org/lkml/2019/6/5/1034
Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
---
 drivers/platform/x86/intel_pmc_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 1d902230ba61..be6cda89dcf5 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -815,6 +815,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
 	INTEL_CPU_FAM6(KABYLAKE_DESKTOP, spt_reg_map),
 	INTEL_CPU_FAM6(CANNONLAKE_MOBILE, cnp_reg_map),
 	INTEL_CPU_FAM6(ICELAKE_MOBILE, icl_reg_map),
+	INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map),
 	{}
 };
 
-- 
2.17.1

Re: [PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

[Andy Shevchenko]

On Fri, Jun 14, 2019 at 11:14 AM Rajneesh Bhardwaj
<rajneesh.bhardwaj@linux.intel.com> wrote:
>
> Ice Lake Neural Network Processor for deep learning inference a.k.a.
> ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core
> driver on it.
>

This will be postponed till next cycle since the CPU model will not
appear before merge window.
So, please, resend than (I guess somewhat in a month).

> Cc: Darren Hart <dvhart@infradead.org>
> Cc: Andy Shevchenko <andy@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org
> Link: https://lkml.org/lkml/2019/6/5/1034
> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> ---
>  drivers/platform/x86/intel_pmc_core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index 1d902230ba61..be6cda89dcf5 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -815,6 +815,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
>         INTEL_CPU_FAM6(KABYLAKE_DESKTOP, spt_reg_map),
>         INTEL_CPU_FAM6(CANNONLAKE_MOBILE, cnp_reg_map),
>         INTEL_CPU_FAM6(ICELAKE_MOBILE, icl_reg_map),
> +       INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map),
>         {}
>  };
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

[Bhardwaj, Rajneesh]

Hi Andy

On 29-Jun-19 6:48 PM, Andy Shevchenko wrote:
> On Fri, Jun 14, 2019 at 11:14 AM Rajneesh Bhardwaj
> <rajneesh.bhardwaj@linux.intel.com> wrote:
>> Ice Lake Neural Network Processor for deep learning inference a.k.a.
>> ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core
>> driver on it.
>>
> This will be postponed till next cycle since the CPU model will not
> appear before merge window.
> So, please, resend than (I guess somewhat in a month).


The dependent CPUID Patch is now upstream, 
https://github.com/torvalds/linux/blob/bed38c3e2dca01b358a62b5e73b46e875742fd75/arch/x86/include/asm/intel-family.h#L59 
so can you please apply this one?


Thank you

Rajneesh


>
>> Cc: Darren Hart <dvhart@infradead.org>
>> Cc: Andy Shevchenko <andy@infradead.org>
>> Cc: platform-driver-x86@vger.kernel.org
>> Link: https://lkml.org/lkml/2019/6/5/1034
>> Signed-off-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
>> ---
>>   drivers/platform/x86/intel_pmc_core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
>> index 1d902230ba61..be6cda89dcf5 100644
>> --- a/drivers/platform/x86/intel_pmc_core.c
>> +++ b/drivers/platform/x86/intel_pmc_core.c
>> @@ -815,6 +815,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
>>          INTEL_CPU_FAM6(KABYLAKE_DESKTOP, spt_reg_map),
>>          INTEL_CPU_FAM6(CANNONLAKE_MOBILE, cnp_reg_map),
>>          INTEL_CPU_FAM6(ICELAKE_MOBILE, icl_reg_map),
>> +       INTEL_CPU_FAM6(ICELAKE_NNPI, icl_reg_map),
>>          {}
>>   };
>>
>> --
>> 2.17.1
>>
>

Re: [PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

[Andy Shevchenko]

On Thu, Jul 25, 2019 at 11:02 AM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@linux.intel.com> wrote:
>
> Hi Andy
>
> On 29-Jun-19 6:48 PM, Andy Shevchenko wrote:
> > On Fri, Jun 14, 2019 at 11:14 AM Rajneesh Bhardwaj
> > <rajneesh.bhardwaj@linux.intel.com> wrote:
> >> Ice Lake Neural Network Processor for deep learning inference a.k.a.
> >> ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core
> >> driver on it.
> >>
> > This will be postponed till next cycle since the CPU model will not
> > appear before merge window.
> > So, please, resend than (I guess somewhat in a month).
>
>
> The dependent CPUID Patch is now upstream,
> https://github.com/torvalds/linux/blob/bed38c3e2dca01b358a62b5e73b46e875742fd75/arch/x86/include/asm/intel-family.h#L59
> so can you please apply this one?

Yes, it's in plan for rc2.

-- 
With Best Regards,
Andy Shevchenko