From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Song Liu <liu.song.a23@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, jolsa@redhat.com,
namhyung@kernel.org, ak@linux.intel.com,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v14 2/3]: perf record: enable asynchronous trace writing
Date: Fri, 2 Nov 2018 19:11:03 +0300 [thread overview]
Message-ID: <376b0d96-a3d7-d136-ef1a-0af5735d7c08@linux.intel.com> (raw)
In-Reply-To: <CAPhsuW76iDvxwqxpH3bdGGGW_5ye5eLM=R2cZsF=P5iPsuB_pQ@mail.gmail.com>
Hi,
On 01.11.2018 21:42, Song Liu wrote:
> On Sun, Oct 14, 2018 at 11:45 PM Alexey Budankov
> <alexey.budankov@linux.intel.com> wrote:
>>
<SNIP>
>> + if (verbose > 0)
>> + pr_info("nr_cblocks: %d\n", rec->opts.nr_cblocks);
>> +
>
> nit: I guess we don't really need this pr_info()?
Diagnostic aid.
Thanks,
Alexey
>
> Other than this,
>
> Acked-by: Song Liu <songliubraving@fb.com>
>
next prev parent reply other threads:[~2018-11-02 16:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 6:26 [PATCH v14 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Alexey Budankov
2018-10-15 6:42 ` [PATCH v14 1/3]: perf util: map data buffer for preserving collected data Alexey Budankov
2018-11-01 18:47 ` Song Liu
2018-11-02 16:14 ` Alexey Budankov
2018-10-15 6:44 ` [PATCH v14 2/3]: perf record: enable asynchronous trace writing Alexey Budankov
2018-11-01 18:42 ` Song Liu
2018-11-02 16:11 ` Alexey Budankov [this message]
2018-10-15 6:46 ` [PATCH v14 3/3]: perf record: extend trace writing to multi AIO Alexey Budankov
2018-11-01 18:30 ` Song Liu
2018-11-02 16:12 ` Alexey Budankov
2018-10-15 10:17 ` [PATCH v14 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads Jiri Olsa
2018-10-25 7:59 ` Alexey Budankov
2018-10-25 8:54 ` Jiri Olsa
2018-10-25 11:12 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=376b0d96-a3d7-d136-ef1a-0af5735d7c08@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liu.song.a23@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox