Re: [PATCH v13 1/2] crypto: AF_ALG: add AEAD support

[Stephan Mueller <smueller@chronox.de>]

Am Thursday 11 June 2015, 15:59:29 schrieb Tadeusz Struk:

Hi Tadeusz,

>Hi Stephan,
>
>On 02/28/2015 11:50 AM, Stephan Mueller wrote:
>> +	err = af_alg_wait_for_completion(ctx->enc ?
>> +					 crypto_aead_encrypt(&ctx->aead_req) :
>> +					 crypto_aead_decrypt(&ctx->aead_req),
>> +					 &ctx->completion);
>> +
>> +	if (err) {
>> +		/* EBADMSG implies a valid cipher operation took place */
>> +		if (err == -EBADMSG)
>> +			aead_put_sgl(sk);
>> +		goto unlock;
>
>Shouldn't we free the TX sgl regardless of the error was?
>Or do we expect that the user will try to read again and it will be Ok the
>second time? Hope you still remember :)

It is the latter: as the crypto was not completed properly, leave the data in 
memory. This may allow a user to send more data if he needs to for completing 
the AEAD operation.

Ciao
Stephan