From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755179AbcEBUuu (ORCPT ); Mon, 2 May 2016 16:50:50 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:63674 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754885AbcEBUuk (ORCPT ); Mon, 2 May 2016 16:50:40 -0400 From: Arnd Bergmann To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Marek Szyprowski , Krzysztof Kozlowski , Mauro Carvalho Chehab , Kamil Debski , Jeongtae Park , Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Subject: Re: [PATCH v2] s5p-mfc: Don't try to put pm->clock if lookup failed Date: Mon, 02 May 2016 22:49:58 +0200 Message-ID: <3778841.dDMP2IXCSZ@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1462216462-32665-1-git-send-email-javier@osg.samsung.com> References: <1462216462-32665-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:y2sKiNg4uJ25HYrZfdK5t8xbJRaId6YDHPY/zJ2v2nJ/0ZGE7Ig KxkEcYzYf3kZc2llRHOZyaL520rhjlkNR91FqNi/fWqreWpqDTvza3LeT62thIJdTR3Qz3E Llpvj+UHU3IAdLreTETWPPdLtSWJvB/+HCquNYCu2cPxNDbx8bRJZhZBKP9Zo2iQxT4iHSQ 5bgYCf7/a/l6ml7HoMptQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Zb70ZqjiBkA=:1co4ICdNVkTSyNZK2L1ydZ iWEoyGY0uajQcVg502GkwPp51tHcor7XaBRItY3KeXFMGPaC8S9Cr/NKxl+VHqHxDqMqgsYy8 PqDbDUV/x9Fe45murlMX0/MaUHX4/O0lMFZcIepa1HxLWH3ps5ne7KVcwZ980vPlc/eMUAQQy /WTRCs1WsyJNMXfBIwtquVtNldiwHByYANTeuin6vu6J71rpr8ac9/S2ftUbEAtkcS1+vNIyE Bdy1nC19X/DrY5+zqlIydSOQT2ZHBPP1vgXXYrp8+dXl6rKS/C8Bc7AiSBm1oc5EWdusVcwLW TrCUlVFqIZ1vKvy0+U4EDkz7MVMEDmqyVrhi+/nJqHOKC6mzcWl+c4tCF7MvaZBr7Zor9YvSu 7V027J6aT6OtXH+MBEkL7C6vPsR0WmfxLGpNI6K3+vjb2ILlzJWf68xRp3kIzNiLjdR7jMwm5 1MaeGO2nEQwHKcdhLIOItq0guooA84uFw0S9XYwSArQEZ4dBYhqNbZ+bcktFJ6aIZ7BXu3K4A sVXN2BAM58UN25mxviJ2ZJ2ccuGWl0LWaGaYVT2wmSlf8C9q97DGcnhBfE492yl1jMetLY4vB CRyyQaS2ZlkeCcF9OmdGMNWisfhjENpDxmjB8RMODNVu++e+eThcb0swn4OlynN8C2Ngv43mp NUHqgzkZic8XL3sRshS3wyYTj0jlR53TYtlolEwP5/92YoWaQ4RlTcW3Wd7Y2M1d6/+VRxBpC yESuQeAI4XBarjvP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 02 May 2016 15:14:22 Javier Martinez Canillas wrote: > Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the > clock field can have a errno pointer value. But s5p_mfc_final_pm() only > checks if .clock is not NULL before attempting to unprepare and put it. > > This leads to the following warning in clk_put() due s5p_mfc_final_pm(): > > WARNING: CPU: 3 PID: 1023 at drivers/clk/clk.c:2814 s5p_mfc_final_pm+0x48/0x74 [s5p_mfc] > CPU: 3 PID: 1023 Comm: rmmod Tainted: G W 4.6.0-rc6-next-20160502-00005-g5a15a49106bc #9 > Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [] (show_stack) from [] (dump_stack+0x88/0x9c) > [] (dump_stack) from [] (__warn+0xe8/0x100) > [] (__warn) from [] (warn_slowpath_null+0x20/0x28) > [] (warn_slowpath_null) from [] (s5p_mfc_final_pm+0x48/0x74 [s5p_mfc]) > [] (s5p_mfc_final_pm [s5p_mfc]) from [] (s5p_mfc_remove+0x8c/0x94 [s5p_mfc]) > [] (s5p_mfc_remove [s5p_mfc]) from [] (platform_drv_remove+0x24/0x3c) > [] (platform_drv_remove) from [] (__device_release_driver+0x84/0x110) > [] (__device_release_driver) from [] (driver_detach+0xac/0xb0) > [] (driver_detach) from [] (bus_remove_driver+0x4c/0xa0) > [] (bus_remove_driver) from [] (SyS_delete_module+0x174/0x1b8) > [] (SyS_delete_module) from [] (ret_fast_syscall+0x0/0x3c) > > Assign the pointer to NULL in case of a lookup failure to fix the issue. > > Signed-off-by: Javier Martinez Canillas > > Acked-by: Arnd Bergmann