From: Viresh Kumar <viresh.kumar@linaro.org>
To: tglx@linutronix.de
Cc: linaro-kernel@lists.linaro.org, linaro-networking@linaro.org,
linux-kernel@vger.kernel.org, fweisbec@gmail.com,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V2 10/19] tick-common: call tick_check_percpu() from tick_check_preferred()
Date: Mon, 21 Apr 2014 15:25:06 +0530 [thread overview]
Message-ID: <37a6c338869c26a16f5fd9d6b33c1aa68ffc2c59.1398072824.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1398072824.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1398072824.git.viresh.kumar@linaro.org>
tick_check_percpu() and tick_check_preferred() are called from two places and in
exactly same order. So, would make sense to call tick_check_percpu() from
tick_check_preferred() instead, so that their caller can just call
tick_check_preferred().
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
kernel/time/tick-common.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c
index 965e9c3..9d3106b 100644
--- a/kernel/time/tick-common.c
+++ b/kernel/time/tick-common.c
@@ -233,6 +233,9 @@ static bool tick_check_percpu(struct clock_event_device *curdev,
static bool tick_check_preferred(struct clock_event_device *curdev,
struct clock_event_device *newdev)
{
+ if (!tick_check_percpu(curdev, newdev, smp_processor_id()))
+ return false;
+
/* Prefer oneshot capable device */
if (!(newdev->features & CLOCK_EVT_FEAT_ONESHOT)) {
if (curdev && (curdev->features & CLOCK_EVT_FEAT_ONESHOT))
@@ -257,9 +260,6 @@ static bool tick_check_preferred(struct clock_event_device *curdev,
bool tick_check_replacement(struct clock_event_device *curdev,
struct clock_event_device *newdev)
{
- if (!tick_check_percpu(curdev, newdev, smp_processor_id()))
- return false;
-
return tick_check_preferred(curdev, newdev);
}
@@ -276,10 +276,6 @@ void tick_check_new_device(struct clock_event_device *newdev)
if (!cpumask_test_cpu(cpu, newdev->cpumask))
goto out_bc;
- /* cpu local device ? */
- if (!tick_check_percpu(curdev, newdev, cpu))
- goto out_bc;
-
/* Preference decision */
if (!tick_check_preferred(curdev, newdev))
goto out_bc;
--
1.7.12.rc2.18.g61b472e
next prev parent reply other threads:[~2014-04-21 9:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-21 9:54 [PATCH V2 00/19] tick: cleanups (Shouldn't change code behavior) Viresh Kumar
2014-04-21 9:54 ` [PATCH V2 01/19] tick: trivial cleanups Viresh Kumar
2014-04-22 21:23 ` Frederic Weisbecker
2014-04-23 4:49 ` Viresh Kumar
2014-04-21 9:54 ` [PATCH V2 02/19] tick: update doc style comments for 'struct tick_sched' Viresh Kumar
2014-04-21 9:54 ` [PATCH V2 03/19] tick: rearrange members of " Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 04/19] tick: move declaration of 'tick_cpu_device' to tick.h Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 05/19] tick: move definition of tick_get_device() " Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 06/19] tick: create tick_get_cpu_device() to get tick_cpu_device on this cpu Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 07/19] tick: initialize variables during their definitions Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 08/19] tick-oneshot: move tick_is_oneshot_available() to tick-oneshot.c Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 09/19] tick-oneshot: remove tick_resume_oneshot() Viresh Kumar
2014-04-21 9:55 ` Viresh Kumar [this message]
2014-04-21 9:55 ` [PATCH V2 11/19] tick-common: remove tick_check_replacement() Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 12/19] tick-common: don't pass 'cpu' & 'cpumask' to tick_setup_device() Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 13/19] tick-common: remove local variable 'broadcast' from tick_resume() Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 14/19] tick-sched: add comment about 'idle_active' in tick_nohz_idle_exit() Viresh Kumar
2014-04-21 23:20 ` Frederic Weisbecker
2014-04-22 4:05 ` viresh kumar
2014-04-21 9:55 ` [PATCH V2 15/19] tick-sched: define 'delta' inside 'if' block in update_ts_time_stats() Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 16/19] tick-sched: remove parameters to {__}tick_nohz_task_switch() routines Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 17/19] tick-sched: remove local variable 'now' from tick_setup_sched_timer() Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 18/19] tick-sched: invert parameter of tick_check_oneshot_change() Viresh Kumar
2014-04-21 9:55 ` [PATCH V2 19/19] tick-sched: rearrange code in tick_do_update_jiffies64() Viresh Kumar
2014-04-30 8:51 ` [PATCH V2 00/19] tick: cleanups (Shouldn't change code behavior) Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37a6c338869c26a16f5fd9d6b33c1aa68ffc2c59.1398072824.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=fweisbec@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).