From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 775DFCA52 for ; Mon, 23 Mar 2026 03:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235658; cv=none; b=FTfkwW0hHD6cVSm9HVWO45Pcn4myFTH02//v68AoG6qEx7d2pWJw9VxTLid8XyMBnleNZ/oCzeb5yQwZxLbiu0L0wlizL0G7/OM7RUpTgvbXge0i4o2mdCjIzWMVb12L4xN/twPo3HCC9aXE1NVImWvTd8tVvgmS2Y5Rih0u/O8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774235658; c=relaxed/simple; bh=HtTo2MR7FX/XSmMO5nwMt6KFsIRKfj2g+cviNbnmnz4=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=TdFo8zTEc9/uWtLhhy0UzvuXvkyWTaCtMpYW+C+AJJUwjLfTxeLmLR5knKvpxQOjHGo6y38BwJSWWFCsEFt9WFA/7Unei3C45iQlSfPxGJCIoMI9rTYdZjv//J+HvWm+mS1asbP7T5buiD4j3M14IpHN3FDwUtnFOaJfD3VihOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qL9O6T6Y; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qL9O6T6Y" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFF61C19424; Mon, 23 Mar 2026 03:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774235658; bh=HtTo2MR7FX/XSmMO5nwMt6KFsIRKfj2g+cviNbnmnz4=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=qL9O6T6Ym2mvTEu+LupaAfpqWIpxfkZDitTar0GCUBTOqfAzltPKgJrEzhoPHL+An egPik7GzlNoLNqBI4zsxrTsjo7Ixc6DDYLpHu8DufUIvfwg1yZ5+a8gJm0YIBxT0Mz a5c3s0fxavSi81Ctp4NnnmKzR0X0pTlIW14x3X/27lak3kB2Zb7+uiQt9JjGf1/Gum zveN52Mp1H58sOgTRX9uRgDCzFyLS44gHqhc5G70AUQQtSuZKIt5/BYqgt5KREAu2h DL5sjr5h5JVoIfnFqafYbwAMy+MD/knk7D5J/Z46oSBy6DkchJa9W6qkv5U3wKUEpc vHY6MebBBwtlw== Message-ID: <37c11065-e055-41b8-82a8-68f2fdf56ac3@kernel.org> Date: Mon, 23 Mar 2026 11:14:14 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, syzkaller-bugs@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH v2] f2fs: evict: truncate page cache before clear_inode To: kth5965@gmail.com, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20260319151121.39737-1-kth5965@gmail.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260319151121.39737-1-kth5965@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/19/26 23:11, kth5965@gmail.com wrote: > Hi Chao, > > Yes, I agree with your point. > > I also think 2) is useful to detect the corrupted inode earlier and to > make the issue visible through log and returned error. > > But 2) alone does not seem sufficient, because we can still reach inode > cleanup later, and then `f2fs_evict_inode()` can still go through the > inline conversion path. > > So it makes sense to me that we need both: > > 1. earlier detection / guarding in sanity check > 2. fixing the empty inline conversion path so page #0 cache is not left > behind > > If this understanding is correct, I will prepare the fix in that > direction. Please go ahead w/ this, thank you! Thanks, > > Thanks.