public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Madadi Vineeth Reddy <vineethr@linux.ibm.com>
To: Chris Hyser <chris.hyser@oracle.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	longman@redhat.com, linux-kernel@vger.kernel.org,
	Madadi Vineeth Reddy <vineethr@linux.ibm.com>
Subject: Re: [PATCH 1/2] sched/numa: Add ability to override task's numa_preferred_nid.
Date: Wed, 16 Apr 2025 12:30:08 +0530	[thread overview]
Message-ID: <37d018ac-ddb2-46c8-908e-9924f0f74e0c@linux.ibm.com> (raw)
In-Reply-To: <20250415013625.3922497-1-chris.hyser@oracle.com>

Hi Chris,

On 15/04/25 07:05, Chris Hyser wrote:
> From: chris hyser <chris.hyser@oracle.com>
> 

[..snip..]

> The following results were from TPCC runs on an Oracle Database. The system
> was a 2-node Intel machine with a database running on each node with local
> memory allocations. No tasks or memory were pinned.
> 
> There are four scenarios of interest:
> 
> - Auto NUMA Balancing OFF.
>     base value
> 
> - Auto NUMA Balancing ON.
>     1.2% - ANB ON better than ANB OFF.
> 
> - Use the prctl(), ANB ON, parameters set to prevent faulting.
>     2.4% - prctl() better then ANB OFF.
>     1.2% - prctl() better than ANB ON.
> 
> - Use the prctl(), ANB parameters normal.
>     3.1% - prctl() and ANB ON better than ANB OFF.
>     1.9% - prctl() and ANB ON better than just ANB ON.
>     0.7% - prctl() and ANB ON better than prctl() and ANB ON/faulting off
> 

Are you using prctl() to set the preferred node id for all the tasks of your run?
If yes, then how `prctl() and ANB ON better than prctl() and ANB ON/faulting off`
case happens?

IIUC, when setting preferred node in numa_preferred_nid_force, the original
numa_preferred_nid which is derived from page faults will be a nop which should
be an overhead.

Let me know if my understanding is correct. Also, can you tell how to set the
parameters of ANB to prevent faulting.

Thanks,
Madadi Vineeth Reddy

> In benchmarks pinning large regions of heavily accessed memory, the
> advantages of the prctl() over Auto NUMA Balancing alone is significantly
> higher.
> 
> Signed-off-by: Chris Hyser <chris.hyser@oracle.com>

[..snip..]

  parent reply	other threads:[~2025-04-16  7:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-15  1:35 [PATCH 1/2] sched/numa: Add ability to override task's numa_preferred_nid Chris Hyser
2025-04-15  1:35 ` [PATCH 2/2] sched/numa: prctl to set/override " Chris Hyser
2025-04-16  7:00 ` Madadi Vineeth Reddy [this message]
2025-04-16 21:13   ` [PATCH 1/2] sched/numa: Add ability to override " Chris Hyser
2025-04-17  3:39     ` Madadi Vineeth Reddy
2025-06-10 18:31 ` Dhaval Giani
2025-06-11 15:12   ` Chris Hyser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37d018ac-ddb2-46c8-908e-9924f0f74e0c@linux.ibm.com \
    --to=vineethr@linux.ibm.com \
    --cc=20250415013625.3922497-1-chris.hyser@oracle.com \
    --cc=chris.hyser@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mgorman@techsingularity.net \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox