From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] tty: Drop duplicate NULL check in TTY port functions
Date: Thu, 3 Feb 2022 09:36:55 +0100 [thread overview]
Message-ID: <37e31d03-eee6-7052-fe32-1f37f1b460e1@kernel.org> (raw)
In-Reply-To: <20220202165704.5680-1-andriy.shevchenko@linux.intel.com>
On 02. 02. 22, 17:57, Andy Shevchenko wrote:
> The free_page(addr), which becomes free_pages(addr, 0) checks addr against 0.
> No need to repeat this check in the callers, i.e. tty_port_free_xmit_buf()
> and tty_port_destructor().
>
> Note, INIT_KFIFO() is safe without that check, because it's aware of kfifo PTR
> versus embedded kfifo.
Not sure what you mean here ^^^? But it might be one of the morning
brain parser errors.
Acked-by: Jiri Slaby <jirislaby@kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/tty_port.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c
> index 4282895ede9e..880608a65773 100644
> --- a/drivers/tty/tty_port.c
> +++ b/drivers/tty/tty_port.c
> @@ -240,11 +240,9 @@ EXPORT_SYMBOL(tty_port_alloc_xmit_buf);
> void tty_port_free_xmit_buf(struct tty_port *port)
> {
> mutex_lock(&port->buf_mutex);
> - if (port->xmit_buf != NULL) {
> - free_page((unsigned long)port->xmit_buf);
> - port->xmit_buf = NULL;
> - INIT_KFIFO(port->xmit_fifo);
> - }
> + free_page((unsigned long)port->xmit_buf);
> + port->xmit_buf = NULL;
> + INIT_KFIFO(port->xmit_fifo);
> mutex_unlock(&port->buf_mutex);
> }
> EXPORT_SYMBOL(tty_port_free_xmit_buf);
> @@ -271,8 +269,7 @@ static void tty_port_destructor(struct kref *kref)
> /* check if last port ref was dropped before tty release */
> if (WARN_ON(port->itty))
> return;
> - if (port->xmit_buf)
> - free_page((unsigned long)port->xmit_buf);
> + free_page((unsigned long)port->xmit_buf);
> tty_port_destroy(port);
> if (port->ops && port->ops->destruct)
> port->ops->destruct(port);
--
js
suse labs
next prev parent reply other threads:[~2022-02-03 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 16:57 [PATCH v1 1/1] tty: Drop duplicate NULL check in TTY port functions Andy Shevchenko
2022-02-03 8:36 ` Jiri Slaby [this message]
2022-02-03 10:40 ` Andy Shevchenko
2022-02-04 14:42 ` Greg Kroah-Hartman
2022-02-04 15:27 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37e31d03-eee6-7052-fe32-1f37f1b460e1@kernel.org \
--to=jirislaby@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox