Re: [PATCH v2] tpm_tis: reserve chip for duration of tpm_tis_core_init

Jarkko Sakkinen
2019-12-27T06:03:52Z

On Fri, 2019-12-27 at 07:42 +0200, Jarkko Sakkinen wrote:
> On Fri, 2019-12-27 at 07:09 +0200, Jarkko Sakkinen wrote:
> > On Thu, 2019-12-19 at 03:07 -0700, Jerry Snitselaar wrote:
> > > > These patches take a usable system and make it unusable:
> > > >
> > > > 1ea32c83c699 tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts
> > > > 5b359c7c4372 tpm_tis_core: Turn on the TPM before probing IRQ's
> > > >
> > > > ...they need to be reverted, or the regression needs to be fixed, but
> > > > asserting that you fixed something else unrelated does not help.
> > > >
> > >
> > > Reverting 1ea32c83c699 ("tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before
> > > probing for interrupts") would at least allow people impacted by this
> > > to boot their systems without disabling the tpm, or blacklisting the
> > > module while we figure this out. From what I can tell the tpm_tis code
> > > was operating in that state since 570a36097f30 ("tpm: drop 'irq' from
> > > struct tpm_vendor_specific") until Stefan's patch.
> >
> > I'll formalize a fix based on the reverts.
> >
> > Sorry for the holiday latency.
>
> OK, have a branch now for the PR:
>
> for-linus-v5.5-rc4
>
> Note: now contains the first revert but I'll add another patch if required.

Jerry, can you check this and send me revert to your earlier fix *if*
required but first test with just this fix applied.

Thanks.

/Jarkko