Re: [PATCH 8/8] staging: r8188eu: remove lines from Makefile that silence build warnings

Greg KH
2021-08-11T07:40:59Z

On Wed, Aug 11, 2021 at 12:50:47AM +0100, Phillip Potter wrote:
> Remove the several lines from the Makefile that append EXTRA_CFLAGS options
> to silence build warnings about unused variables, unused functions and such
> like. This will enable cleanup of missed warnings, and easier spotting
> of future such problems.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/Makefile | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/Makefile b/drivers/staging/r8188eu/Makefile
> index 152d6325b4d9..7f6658f931d1 100644
> --- a/drivers/staging/r8188eu/Makefile
> +++ b/drivers/staging/r8188eu/Makefile
> @@ -2,15 +2,6 @@ SHELL := /bin/bash
> EXTRA_CFLAGS += $(USER_EXTRA_CFLAGS)
> EXTRA_CFLAGS += -O1
>
> -EXTRA_CFLAGS += -Wno-unused-variable
> -EXTRA_CFLAGS += -Wno-unused-value
> -EXTRA_CFLAGS += -Wno-unused-label
> -EXTRA_CFLAGS += -Wno-unused-parameter
> -EXTRA_CFLAGS += -Wno-unused-function
> -EXTRA_CFLAGS += -Wno-unused
> -
> -EXTRA_CFLAGS += -Wno-uninitialized
> -

Ah, that is why I didn't see any warnings! Thanks for these changes,
will go queue them up now.

greg k-h