Re: [PATCH 1/8] staging: r8188eu: remove unused functions from os_dep/ioctl_linux.c

Greg KH
2021-08-11T07:40:40Z

On Wed, Aug 11, 2021 at 12:50:40AM +0100, Phillip Potter wrote:
> Remove unused functions that are now no longer called as a result of the
> removal of rtw_ioctl in a previous patch. This includes functions not
> directly called from rtw_ioctl, but anything in that specific
> call-chain.
>
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> drivers/staging/r8188eu/os_dep/ioctl_linux.c | 1538 ++----------------
> 1 file changed, 127 insertions(+), 1411 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/ioctl_linux.c b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> index 4e21801cbfcf..1ccc5f8de1ee 100644
> --- a/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> +++ b/drivers/staging/r8188eu/os_dep/ioctl_linux.c
> @@ -1539,7 +1539,6 @@ static int rtw_wx_get_essid(struct net_device *dev,
> wrqu->essid.length = len;
> wrqu->essid.flags = 1;
>
> -exit:

This is not a "function", but a label that was not used.

I'll take this but be more careful next time in the description of
patches as to what they are doing...

thanks,

greg k-h