From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from dvalin.narfation.org (dvalin.narfation.org [213.160.73.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B7120B80B for ; Sat, 1 Aug 2026 09:54:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.160.73.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785578065; cv=none; b=GPRCd+qKgpI4sM5IhCHOmIhGw9FJgh/VZhothWSJ9TZnUWtbGwpI+Q7pst22RkU6ql6rK5QkbneKxWdlAXSF9hc9qn97+HWIL0ItM+OBjXcMA+TTaAM8MubovWx+UryGEQnRYdcSnJbctwxfcy7WzdwQ5qS2F0XY3hssajFaWYs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785578065; c=relaxed/simple; bh=3Z8lIK0nSbsbkbYZewiw4nsiBaSvTdY1L0KS4bzx8Z0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=iJKEUFKu4ZikjqB7UhHaSKMBNjteMtHHXKy9Fp5eoKzOkkCgK0g0a1lf8jKDKFjFsFqABJC47kMNzcpzR+jeteZ69cdAKkfERM0Sj9LU0GcY5facwn4WnCMBBJIPQ1fNplMeLeOtfyFcmgTBNNxUOmyeAlmhwBMAp7xQV67STks= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=narfation.org; spf=pass smtp.mailfrom=narfation.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b=YPNFyxQS; arc=none smtp.client-ip=213.160.73.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=narfation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=narfation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=narfation.org header.i=@narfation.org header.b="YPNFyxQS" Received: by dvalin.narfation.org (Postfix) id 3AD2620019; Sat, 01 Aug 2026 09:54:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=narfation.org; s=20121; t=1785578051; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=31562uwLfTYNq6vgE78qecgqtQEB+BtbSBg2bmrtk2g=; b=YPNFyxQS7DoF+/7/wXiAfuu71tAm1xL0rMWtDeYulWx0q3ZGkWI1urZ/cAPM7I8DrAjlRN iSmuGKXoGTyoGIR3yRz7vlXqTTvW+KLR6bABP9ZUOnUyUjSkAYa0LQXHcVOxUZTg7rXIjC lJn4rzySb9f7Ejk9c3UGAjafIi7q/Pw= From: Sven Eckelmann To: David Lee , Kyle Zeng Cc: Dominik 'Disconnect3d' Czarnota , b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org, Konstantin Ryabitsev , "Kernel.org Tools" , Andy Whitcroft , Joe Perches Subject: Re: [PATCH] batman-adv: reject unrepresentable multicast TVLV offsets (+ b4 check signed-off-problems) Date: Sat, 01 Aug 2026 11:54:03 +0200 Message-ID: <3801416.R56niFO833@sven-desktop> In-Reply-To: <20260731135222.566367-1-david.lee@trailofbits.com> References: <20260731135222.566367-1-david.lee@trailofbits.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3933016.MHq7AAxBmi"; micalg="pgp-sha512"; protocol="application/pgp-signature" --nextPart3933016.MHq7AAxBmi Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8"; protected-headers="v1" From: Sven Eckelmann Date: Sat, 01 Aug 2026 11:54:03 +0200 Message-ID: <3801416.R56niFO833@sven-desktop> In-Reply-To: <20260731135222.566367-1-david.lee@trailofbits.com> References: <20260731135222.566367-1-david.lee@trailofbits.com> MIME-Version: 1.0 On Friday, 31 July 2026 15:52:22 CEST David Lee wrote: > Signed-off-by: Kyle Zeng Another thing just realized (and for whatever reason it was not shown by b4): Who is Kyle Zeng here (what does kylebot have to do with the patch)? David Lee is here marked as the author but didn't even Signed-off-by the patch. See https://docs.kernel.org/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin (see the end of mail of pending things for this patch) @Konstanin (Joe/Andy): Is it to be expected that `b4 review track 20260731135222.566367-1-david.lee@trailofbits.com` -> `b4 review tui` -> "review" -> "checks" patch doesn't show the Signed-off-by error in the checkpatch check view? When doing it manually, it works as expected: $ b4 am 20260731135222.566367-1-david.lee@trailofbits.com [..] $ ./scripts/checkpatch.pl -q --terse --no-summary ./20260731_david_lee_batman_adv_reject_unrepresentable_multicast_tvlv_offsets.mbx ./20260731_david_lee_batman_adv_reject_unrepresentable_multicast_tvlv_offsets.mbx:52: ERROR: Missing Signed-off-by: line by nominal patch author 'David Lee ' $ b4 --version 0.15.2 The difference comes from the "--mailback" option which b4 adds also to checkpatch. I have therefore also Cc'ed Joe Perches and Andy Whitcroft because of this suppressed error. The following change would produce the output but I have no glue and just fiddled around with the script without understanding the bigger concept (of checkpatch and why b4 uses --mailback): diff --git i/scripts/checkpatch.pl w/scripts/checkpatch.pl index 7a846a3ea1273..ccb2ec78193e0 100755 --- i/scripts/checkpatch.pl +++ w/scripts/checkpatch.pl @@ -7846,12 +7846,6 @@ sub process { exit(0); } - # In mailback mode only produce a report in the negative, for - # things that appear to be patches. - if ($mailback && ($clean == 1 || !$is_patch)) { - exit(0); - } - # This is not a patch, and we are in 'no-patch' mode so # just keep quiet. if (!$chk_patch && !$is_patch) { @@ -7902,6 +7896,12 @@ sub process { } } + # In mailback mode only produce a report in the negative, for + # things that appear to be patches. + if ($mailback && ($clean == 1 || !$is_patch)) { + exit(0); + } + print report_dump(); if ($summary && !($clean == 1 && $quiet == 1)) { print "$filename " if ($summary_file); (this is just to show the cause - not meant as anything which should be applied) Regards, Sven --nextPart3933016.MHq7AAxBmi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQS81G/PswftH/OW8cVND3cr0xT1ywUCam3COwAKCRBND3cr0xT1 y0m5AQChINdIzm/w0zU7bfoEbd9BJ5+g/WSUN+VWYEDRgtHNCwD+IW00Wn77OkYu fXiFXJUuvzn420Zc+jPEKhYkJB01gw8= =/H5g -----END PGP SIGNATURE----- --nextPart3933016.MHq7AAxBmi--