From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758604AbbKSPYG (ORCPT <rfc822;w@1wt.eu>);
	Thu, 19 Nov 2015 10:24:06 -0500
Received: from mout.kundenserver.de ([212.227.126.135]:58367 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757113AbbKSPYE (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 19 Nov 2015 10:24:04 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Punit Agrawal <punit.agrawal@arm.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>, Jon Medhurst <tixy@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        Liviu Dudau <Liviu.Dudau@arm.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, arm@kernel.org
Subject: Re: [PATCH] scpi: hide get_scpi_ops in module from built-in code
Date: Thu, 19 Nov 2015 16:23:31 +0100
Message-ID: <3802372.zWzDBWFCTp@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <9hhoaespm8p.fsf@e105922-lin.cambridge.arm.com>
References: <4740279.aWlP1tqJLa@wuerfel> <9hhoaespm8p.fsf@e105922-lin.cambridge.arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:5Tu/mxU0VFuoZnvuCdChqn9ZU8FNIOBiaScryAgQz7DYS+kgYSD
 Zm/QQTrGkANeVrZHFA5kY0U6H3BVGYtLJhhUa4uON6LO2OUh43e7Nul8inTz7sixmv60Wzb
 eo5ldPx08ZgVoFy9mXPUTuALPufsYck+vnoLKtRK0mM5HDak/ImnG2oP/x2uOQAdQF4oNF/
 aTh6X27uxbEhTrSvCaw7g==
X-UI-Out-Filterresults: notjunk:1;V01:K0:+y0dUDA1ktY=:+bwycNvUoMCpxp3ITbuvdM
 j+mDqAFAzgLTqDLhGY/L6Cran9g4w2j8jfDSvc5f1nZ1hT4jXudfXqxg/qCr0/6QBlU5yx7rj
 fmKUMMQr4sysIoCrrVAadXP4lwHjimFYyQGioXZvXVmymPCElcSfIOxX0/+ln2j6V4pWStST+
 2H5YsRKM2RmusLimxwgrtZOoZZcMn1Bg8Fggj3tMT+7HtdNN4mwePhX9qQuYJWZdF6OTwKFuW
 f9bp28KKuAIg7J9OyBNheDyr6wBJ1G1vU082MeN1kYE9g9anrPcjiPIIvPe63o3eM2GswY5xb
 NMpOTUo5hee1TZlCeogw8sC6YmuosQPc7bKJLBNRoFyz2hRnS4W5JiH93DA5wFXl1q67bDi08
 VYN+4dOM4B6t/MGm8AJwLYGnHMN3Senq2erey4YEsyGwfmRR327EZwIiONAeLTqbMUSqMPI5I
 aeVHmQgdnFQ7uac58CZbJuGfjm5xV4xppXpFk5RX0q567DzTy9YEPmq8VmCBpXhzAzZoK11tQ
 NzJz+EG+/40A5kU9Lo2apbdhFwTY4GqgIm1m6bmuVZnYp+n5YUtkShz5uVG2D5c5HliIaqJVP
 CFtigKEz/kGeLlCkga9fSOeVSwxUkuBhVvfHK0bM42Mgey4taIFy56Ob7f/PkNZO/0rrjV9MC
 s7YmOVPWTWslI+1Af7pq5V1tNH5THWgeU2+WtqA5UfqCHZLOLFsgVjzFGN+sWeR64j9c4AUB9
 JEoebdDoUESM1Ma8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 17 November 2015 17:30:14 Punit Agrawal wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
> 
> > The scpi_clock driver can be built-in when CONFIG_COMPILE_TEST
> > is set even when ARM_SCPI_PROTOCOL is a loadable module, and
> > that results in a link error:
> >
> > drivers/built-in.o: In function `scpi_clocks_probe':
> > (.text+0x14453c): undefined reference to `get_scpi_ops'
> >
> > Using #if IS_REACHABLE() around the get_scpi_ops() declaration
> > makes it build successfully in this case for compile-testing,
> > but the effect is the same as when ARM_SCPI_PROTOCOL is
> > disabled, as the code will not be used.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Makes sense. Thanks, Arnd!
> 
>        Acked-by: Punit Agrawal <punit.agrawal@arm.com>
> 

I've added it to arm-soc fixes now.

	Arnd