public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: zbr@ioremap.net
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "kernel@pengutronix.de" <kernel@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better
Date: Tue, 18 Feb 2014 05:26:20 +0400	[thread overview]
Message-ID: <380901392686780@web3m.yandex.ru> (raw)
In-Reply-To: <1392329128-6221-1-git-send-email-u.kleine-koenig@pengutronix.de>

Hi

14.02.2014, 02:05, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>:
> of_get_gpio() might return -EPROBE_DEFER meaning that the driver
> providing the gpio isn't ready yet. If that happens for the first gpio
> the resulting kernel output without this patch is:
>
>         w1-gpio somename: Failed to parse DT
>         platform somename: Driver w1-gpio requests probe deferral
>
> The first message is misleading and so is suppressed with this patch.
>
> Further if determining the gpio to switch the external pullup yields
> -EPROBE_DEFER this error should be passed back to the caller instead of
> just continuing without pullup.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

I'm ok with this patch, but I virtually do not understand what it does :)
Since I know nothing about device trees.

But yet it looks innocent enough to merge.

  reply	other threads:[~2014-02-18  1:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-13 22:05 [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better Uwe Kleine-König
2014-02-18  1:26 ` zbr [this message]
2014-02-18  8:24   ` Uwe Kleine-König
2014-02-18 14:34     ` Evgeniy Polyakov
2014-02-18 17:47       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=380901392686780@web3m.yandex.ru \
    --to=zbr@ioremap.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox