Re: [PATCH] w1-gpio: handle of_get_gpio() returning -EPROBE_DEFER better

Greg Kroah-Hartman
2014-02-18T17:46:06Z

On Tue, Feb 18, 2014 at 06:34:07PM +0400, Evgeniy Polyakov wrote:
> Hi
>
> 18.02.2014, 12:24, "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>:
>
> > The thing is that the w1-gpio device might be probed before the gpio's
> > controller is available. In this case of_get_gpio returns -EPROBE_DEFER
> > and this makes the device core retry probing the w1-gpio device later
> > again. So this is not a dt-parsing problem but just dependency stuff.
> >
> > The 2nd issue addressed didn't happen to me, but it might occur that the
> > first of_get_gpio for the data pin succeeds, but the getting the pullup
> > gpio fails with -EPROBE_DEFER (e.g. because it sits on a different
> > controller). In this case you still want to retry probing later instead
> > of ignoring the problem.
> >
> > Does that make it clearer?
>
> Well, yes, thank you :)
>
> Greg, please pull this patch into your tree.

Already merged :)