From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754480AbbKLOX0 (ORCPT ); Thu, 12 Nov 2015 09:23:26 -0500 Received: from mout.kundenserver.de ([212.227.17.10]:55557 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752537AbbKLOXY (ORCPT ); Thu, 12 Nov 2015 09:23:24 -0500 From: Arnd Bergmann To: Steven Rostedt , Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Gleixner Subject: [PATCH] sched/rt: hide push_irq_work_func declaration Date: Thu, 12 Nov 2015 15:22:22 +0100 Message-ID: <3810009.VdDTV0h1Qp@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:WKZhYHgTsn1dpXXFF1MN+9voXRe7NMVYpkEM5At111qfYALbt1R 7CoHyYbT7T/iQGFJEX/mKo498v7xvrmIE2ibRlUK9uYshRziCyEcW4NRbrcahTvKXwIctLD tqtwk4L1b+FZWNjnzeDwSYq3FSBRn2CbXotwxvs3xr2YrIt42+klu2xAplPv77KIBk9CaHg metWXKt26g3LnO0TEcXaQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/QGfOBO3NfM=:/2sX8LWQ893l5VZRaMrIW7 Q6tT45Qg0ZnA+MvDZK+oLV2Xo7EwPyIMWWbjP1msep39RhFtg78iKDb/+Tt+E9CwI7iocxVH3 YCr48q0ruua6xbiRbgpfOi4LXvg0224/HdE3rZw6EBgnvXgv7PrhqkKgOJ2FT6mwnkhYZyQSd qekhaC8g6QtxcqjXr2+LWveVGvBZKoA3dLL1/fNpn+q2F0YpA8xXJfhk1fUff2HIOXkCeHBma Sm5FRProO1bqvWYASTflbuA9f2boORenAP+KW8uMh6seCtvCG5BLfKjPp4h6lZAOqH3tj82nb +GRJHdFApD+eFSlgYO63tdMkL79LN5ZFmZnHhDm8LziIgcUgIfuWOcJ5NIe8A2Cvo5Pj3CvGq d1s0u+6PlthbW8Z8YQtH5mb01zrfNIntxrZlPT0Arhro/ruZmmMtzVizHQfDxnFqJqSuk0hw1 fDcFUsGkGrNlzcDhzFU5ChB3+KBevkIhLFPgm3fYjUffpD5PRHNQn9JBr83qbkgMh4waLoVzX Ug8klO+iQEMFTSokMkDVRhPZHzdVKfI0wklZGby1m2xBjWhzxhI1/I/fvFG3P2WX78S/N1VCt lUPaiuPFO0npE/Of1njNnFYxSYY3b9RG+O3JXziWgac27kkAs4VAN/6FEfZ/vdj+VX9Tf6z7Q qrCCNhBdnNs7cLYf12bVA3qVwN/pHIfAZymBUb18E1jhFdzYdYxW6R4XjlgBR0C3RJU0DwvCb e3yJ7nbyU5a6L1tN Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The push_irq_work_func() function is conditionally defined only when both CONFIG_SMP and HAVE_RT_PUSH_IPI are defined, but the forward declaration remains visibile without HAVE_RT_PUSH_IPI, causing a gcc warning in ARM64 allnoconfig: kernel/sched/rt.c:68:13: warning: 'push_irq_work_func' declared 'static' but never defined [-Wunused-function] This changes the code to use the same condition for both the declaration and the function definition, which gets rid of the warning. Signed-off-by: Arnd Bergmann Fixes: b6366f048e0c ("sched/rt: Use IPI to trigger RT task push migration instead of pulling") --- Found on arm64 allnoconfig diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index e3cc16312046..ce7b36d6f477 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -64,7 +64,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b) raw_spin_unlock(&rt_b->rt_runtime_lock); } -#ifdef CONFIG_SMP +#if IS_ENABLED(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) static void push_irq_work_func(struct irq_work *work); #endif