From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752372AbcDWWRV (ORCPT ); Sat, 23 Apr 2016 18:17:21 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:64825 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbcDWWRU (ORCPT ); Sat, 23 Apr 2016 18:17:20 -0400 From: Arnd Bergmann To: Andre Przywara Cc: Will Deacon , Catalin Marinas , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] generic syscalls: wire up preadv2 and pwritev2 syscalls Date: Sun, 24 Apr 2016 00:16:50 +0200 Message-ID: <3816292.4K8FR7W2O1@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1460366266-29378-1-git-send-email-andre.przywara@arm.com> References: <1460366266-29378-1-git-send-email-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:jK37s7Pwb/8PxS7isW2B2CQsSZk3ChfYTBpi8kUQWFRScevqoBf rIt1M+R6j7JmHgT2gLug1jZdb8tKpwtuYhdCrNAdn0O8zxDUzVFGdFQr3j4I4vKYH0Y37WF esDL7jhdH6dpZvU5sgVu8wlP9VzAUPqxXhbPnyIKy9kSFqPwKdH1SqxwHBLnekYt3rPZI4i s6hY3m4PXZWg3Mv2YoV+g== X-UI-Out-Filterresults: notjunk:1;V01:K0:z/2TaFdFHZE=:c51bikJS1A0uR1THoCyJ9m NChxy5C9mGZeXdcqzbHPf1Um10c21MYUM3rd4oF9ps+8QYk/s8MzYADx1U3V+N4nSOCt2JKdr WE4zRLHTOHFoQYDgVW/JkLrY0gY4piM/8nMXzv673QAco0gEKrvopikV7Vaxj7/l+yhY4wQBf wNoBY3a7OwE5TgJOgcG7xELr4lQaZOst9JejjXJ2yK6girTbpsCZ+35i/2sJOUJsPVa5nLbGM kHfwZ1DL4VGhcQpSjYzKrUlznVhOYx/eSewNgR9TG9Yyzo1yACs838zzfqZdka6yQGr0S7CQT JwA1bSGag9o1cLprXzYRhJ+6iUC38u6U8SiOARCF6jxfkrF1IotGM1YAdxvFuQM/8l1hElkUw VwMd0WqPN7egvvenqRZnHfgRPB0mKhFPe3FjB+tWtBWCfSEz16wCPVAo5l3wgM7QB8amMtXwT c+mhCJubikjX2zx1IsJn+L26/THC55917fjvB3RmAo8bAshPwytjVrVUWQaGA9PEksmqY2ep+ tyKQRKVnwhnPgLkgoDisS94cqPFgHFUMf3FIQjIwKSlF9Tk5zX4ghz5tlXSWLXBMKTDRCd+qh ib94yHUfc4FMonldt9IjjvX3v8yVAEkWpz+fYKrseg2QN3LpYicAwBXE5FGDW0ngWNy5eAeyt QawqfbjwQc5GIoTp88a9xnzPM2iRVLTjP2h6v1HhzGcEErO61VtvRrfquIzj/4Ukel1mnmymS dEdSclcsVOHYIcuQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 11 April 2016 10:17:46 Andre Przywara wrote: > These new syscalls are implemented as generic code, so enable them for > architectures like arm64 which use the generic syscall table. > > Signed-off-by: Andre Przywara > I've forwarded it now as a pull request. Generally speaking, I'd much prefer anyone who adds a syscall to update asm-generic/unistd.h as well (as documented in Documentation/adding-syscalls.txt), there is no need for me to put those patches into the asm-generic git tree first. On a related topic, I've been thinking (for years) about coming up with a way to have all future syscalls just get added to a single file in the kernel to have them appended to the tables for all architectures. There are two basic methods that seem appropriate here for avoiding the split between unistd.h and syscalls.S: a) The current asm-generic method of interleaving the __NR_* macro definitions and the entry in a .c file array, including the header multiple times to get all the tables b) generating both files from an input like x86 does with arch/x86/entry/syscalls/ infrastructure I think we need something similar to b) but with some extensions to allow extending the architecture specific tables in a nice way, rather than having to have one file per architecture. Arnd