From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033417AbbKFUac (ORCPT ); Fri, 6 Nov 2015 15:30:32 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:49763 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032899AbbKFUa3 (ORCPT ); Fri, 6 Nov 2015 15:30:29 -0500 From: Arnd Bergmann To: Guenter Roeck Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] net: hisilicon: Never build on SPARC Date: Fri, 06 Nov 2015 21:30:17 +0100 Message-ID: <3819536.piFndcizrV@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151106191652.GA4046@roeck-us.net> References: <1445437773-23261-1-git-send-email-linux@roeck-us.net> <20151021215320.GB23371@roeck-us.net> <20151106191652.GA4046@roeck-us.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:STe3yHy6AhBkunZrGITRcZLqiUKlMocLpvmfD8aqwFTThumlNC0 ZCw4+o1ej9jtJ6H0UOi5qkyApKC36Yse3KRZ3Zj30PIj7L06IvYjYDufSAB4VyowyEVMmQr g36ENVn8tVvz8L+Q/BVw0J+IsD6wIY1qeNNvGrUyXpfnQUYsPdjQ25ocRhm2xaf4gPdS+Hx 368gLn8etKwo9icNE+CKA== X-UI-Out-Filterresults: notjunk:1;V01:K0:xIxWZsUJdhA=:HnxUL12XOllYWmWTvntVbo qFYjKlxjRwSGbgl2BWUFraJxKWy+98l9Eh9XdwqS3HRuGTp9WJE2znfp2UUfaHLEWyx6cDIU+ LKgKv9yANWQLZUOlMoy+HDxggRStltjrIV8PtMsZa3Qw/NH3NYXinlfk+e5rxGjZ1ZNo24VOZ ZbG8xXtSDAy5Z6gTAlzVUGJjYrlngUCJGXAP9hqzGmmhlC65cQLKTNPKLb7B3uF+HvBAcOHPI HqP1RFutdmfBsS6LfM1Qzpw/3fS6OCoqo8RnFlOBWwpNRhRVj2X6XS5pO3Wq2YOIV/DV2Xqr4 OQNSCNKInNy9zD5fP3Re+vrkZz3BsSxy0eWusSkD3iLNHV41F95HzZQb9Ci96WU5GhXPMnIZJ IYjljUzpBGV1lW4Grtqt0L1zxNjOUJr23a0A0yJKsS3njOUvs0EF1wcJkX9w7dSnANh/FrExJ QZk6RGs9ghNv/7EvYM16vySnpJ8izNpMZSEIe3dJMaJRtgIFei+lgf0S2HVE9y1m6wVqSO14+ apwFol3p0F9/kTI50zY68HrJFBJ2t/uZVVEKBaN3zKj2GXRAqtCVV+dafti1PMF88Ms4/clvl 1lb2vgT0uQPZ17OLIZbMjz0Ap98sYd8zLyouDmuIxaGKezypwc4M+loiDEEBWIxElXhDkrbUx zUpxF3hd1x0w9K2zHC6UY6hvKP+90g60WzNZfVoFPa2Kxw/JQNUkmekc5OKpwZkD70NxuiR8h 8ZnJ8Cm/s25B+PAP Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 06 November 2015 11:16:52 Guenter Roeck wrote: > On Wed, Oct 21, 2015 at 02:53:20PM -0700, Guenter Roeck wrote: > > On Wed, Oct 21, 2015 at 09:11:53PM +0200, Arnd Bergmann wrote: > > > On Wednesday 21 October 2015 10:03:05 Guenter Roeck wrote: > > > > Anyway, if it gets that complicated, I think we should stick with > > > > just returning OF_BAD_ADDR. The above really suggests the need for > > > > an architecture specific solution. > > > > > > Probably no harm in this really: the far more common > > > of_address_to_resource() and of_iomap() helpers are equally > > > broken on SPARC and we just return a runtime error for those > > > as well without CONFIG_OF_ADDRESS rather than breaking the build. > > > > > Agreed. Given this, returning OF_BAD_ADDR sounds like a better choice. > > > Arnd, > > do you know if a fix for this problem is pending in some branch ? > Mainline sparc builds are now affected. > I don't think anyone wrote the patch to do this. Can you send one? Arnd