Re: [PATCH] Hot swap CPU support for 2.4.1

Re: [PATCH] Hot swap CPU support for 2.4.1

[Frank Davis]

Hello,
   Which archs still need to implement it? I briefly looked over the patch and noticed that it had i386, ppc, mips64, and s390 already there.
Regards,
Frank

>Hi all,
>
>I did the infrastructure, Anton did the bugfinding and PPC >support,
>aka. the hard stuff.  Other architectures need to implement
>__cpu_disable, __cpu_die and __cpu_up for them to work.  >Volunteers
>appreciated.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Hot swap CPU support for 2.4.1

[Rusty Russell]

In message <382569872.981348677202.JavaMail.root@web340-wra.mail.com> you write
:
> Hello,
>    Which archs still need to implement it? I briefly looked over the patch an
d noticed that it had i386, ppc, mips64, and s390 already there.

PPC is there (kinda hackish, but proof of concept).  For the rest, I
don't consider:

	return -ENOSYS;

an implementation.  Someone who understands the interrupt controllers
and vagarities for each platform needs to implement them...

Rusty.
--
Premature optmztion is rt of all evl. --DK
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

[PATCH] Hot swap CPU support for 2.4.1

[Rusty Russell]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

Hi all,

I did the infrastructure, Anton did the bugfinding and PPC support,
aka. the hard stuff.  Other architectures need to implement
__cpu_disable, __cpu_die and __cpu_up for them to work.  Volunteers
appreciated.

	This patch allows you to down & up CPUs as follows:
	# echo 0 > /proc/sys/cpu/0/online
	# echo 1 > /proc/sys/cpu/0/online

The relatively trivial patch works as follows:

1) Implements synchronize_kernel() (thanks Andi Kleen for forwarding
   Paul McKenney's quiescent-state ideas) which waits for a schedule
   on all CPUs.
2) All CPU numbers are now physical: removes cpu_number_map,
   cpu_logical_map and smp_num_cpus.
3) Adds cpu_online(cpu) and cpu_num_online() macros.
4) Adds cpu_down() and cpu_up() calls, which call arch-specific
   __cpu_disable(cpu), __cpu_die(cpu) and __cpu_up(cpu).
5) Fixes schedule() to check allowed_cpus even if rescheduling same
   task.

Since it's 60k long, mime attached bzip2.

Go hack!
Rusty Russell & Anton Blanchard
--

[-- Attachment #2: hotswap CPU patch --]
[-- Type: application/octet-stream, Size: 13894 bytes --]

Re: [PATCH] Hot swap CPU support for 2.4.1

[Lars Marowsky-Bree]

On 2001-02-05T15:00:40,
   Rusty Russell <rusty@linuxcare.com.au> said:

> I did the infrastructure, Anton did the bugfinding and PPC support,
> aka. the hard stuff.  Other architectures need to implement
> __cpu_disable, __cpu_die and __cpu_up for them to work.  Volunteers
> appreciated.

Rusty, what would be needed to "hot-add" CPUs ?

Sincerely,
    Lars Marowsky-Brée <lars.marowsky-bree@sap.com>
    SuSE Linux AG at the SAP LinuxLab - lmb@suse.de

-- 
Perfection is our goal, excellence will be tolerated. -- J. Yahl

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Hot swap CPU support for 2.4.1

[Anton Blanchard]

 
> Rusty, what would be needed to "hot-add" CPUs ?

The PPC version at the moment simply locks a cpu in the idle loop
with __cli(); while(1); for cpu down and jumps out of it for cpu up.
Good for testing but not very useful. After talking to paulus we
will use the RTAS cpu stop and cpu start.

In order to bring a new cpu up you will need to duplicate a lot of
the stuff in smp_boot_cpus or else just set up all NR_CPUS of these
structures (eg NR_CPUS idle threads etc) at boot time.

Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Hot swap CPU support for 2.4.1

[Pavel Machek]

Hi!

> I did the infrastructure, Anton did the bugfinding and PPC support,
> aka. the hard stuff.  Other architectures need to implement
> __cpu_disable, __cpu_die and __cpu_up for them to work.  Volunteers
> appreciated.
> 
> 	This patch allows you to down & up CPUs as follows:
> 	# echo 0 > /proc/sys/cpu/0/online
> 	# echo 1 > /proc/sys/cpu/0/online
> 
> The relatively trivial patch works as follows:
> 
> 1) Implements synchronize_kernel() (thanks Andi Kleen for forwarding
>    Paul McKenney's quiescent-state ideas) which waits for a schedule
>    on all CPUs.
> 2) All CPU numbers are now physical: removes cpu_number_map,
>    cpu_logical_map and smp_num_cpus.
> 3) Adds cpu_online(cpu) and cpu_num_online() macros.
> 4) Adds cpu_down() and cpu_up() calls, which call arch-specific
>    __cpu_disable(cpu), __cpu_die(cpu) and __cpu_up(cpu).
> 5) Fixes schedule() to check allowed_cpus even if rescheduling same
>    task.

This is not quite right:

@@ -1643,7 +1643,7 @@
                printk(KERN_NOTICE "apm: disabled on user
request.\n");
                return -ENODEV;
        }
-       if ((smp_num_cpus > 1) && !power_off) {
+       if ((num_online_cpus() > 1) && !power_off) {
                printk(KERN_NOTICE "apm: disabled - APM is not SMP
safe.\n");
                return -ENODEV;
        }
@@ -1697,7 +1697,7 @@

        kernel_thread(apm, NULL, CLONE_FS | CLONE_FILES |
CLONE_SIGHAND | SIGCHLD);

-       if (smp_num_cpus > 1) {
+       if (num_online_cpus() > 1) {
                printk(KERN_NOTICE
                   "apm: disabled - APM is not SMP safe (power off
active).\n");
                return 0;

I do not think it is safe to call APM when there is just CPU #5
running. smp_num_cpus in this context means "if we ever had more than
boot cpu".
								Pavel
-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Hot swap CPU support for 2.4.1

[Rusty Russell]

In message <20010211002955.I7877@bug.ucw.cz> you write:
> This is not quite right:
> 
> @@ -1643,7 +1643,7 @@
>                 printk(KERN_NOTICE "apm: disabled on user
> request.\n");
>                 return -ENODEV;
>         }
> -       if ((smp_num_cpus > 1) && !power_off) {
> +       if ((num_online_cpus() > 1) && !power_off) {
>                 printk(KERN_NOTICE "apm: disabled - APM is not SMP
> 
> I do not think it is safe to call APM when there is just CPU #5
> running. smp_num_cpus in this context means "if we ever had more than
> boot cpu".

Um, it's not safe to call APM in SMP full stop: we try anyway.
However, this code changes nothing since it's only run at boot.

Cheers,
Rusty.
--
Premature optmztion is rt of all evl. --DK
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/