Re: [PATCH v5 10/10] drm/rockchip: dw_hdmi_qp: Restrict HPD event to the affected connector

Cristian Ciocaltea
2026-04-28T14:10:46Z

On 4/28/26 4:53 AM, Dmitry Baryshkov wrote:
> On Sun, Apr 26, 2026 at 03:20:22AM +0300, Cristian Ciocaltea wrote:
>> Switch from drm_helper_hpd_irq_event(), which polls all connectors, to
>> drm_connector_helper_hpd_irq_event(), which runs the detect cycle only
>> on the affected connector.
>>
>> This avoids unnecessary work and redundant detect calls on unrelated
>> connectors.
>
> This also doesn't feel correct. The dw_hdmi_qp is a bridge. As such it
> should be using drm_bridge_hpd_notify() rather than any of the mentioned
> functions. Would it be better to add the a corresponding wrapper to the
> dw_hdmi_qp API and call one there?

Let me try that.

> Also consider implementing the
> .hpd_enable() and .hpd_disable() callbacks for the bridge, which would
> remove the necessity to call enable the IRQ in the bind function.

Ack.

Thanks,
Cristian