From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932363AbbKLQVH (ORCPT ); Thu, 12 Nov 2015 11:21:07 -0500 Received: from mout.kundenserver.de ([212.227.126.131]:51275 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932070AbbKLQVB (ORCPT ); Thu, 12 Nov 2015 11:21:01 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Steven Rostedt , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org Subject: [PATCH v2] sched/rt: hide push_irq_work_func declaration Date: Thu, 12 Nov 2015 17:19:58 +0100 Message-ID: <3828565.oKfGk7yNIT@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <3810009.VdDTV0h1Qp@wuerfel> References: <3810009.VdDTV0h1Qp@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Suuw3giAdADlo1AlBQNJugxLxQ1su3dLgHn8HmlEEIei4SyqYnu 5hQNQvlNEBCMHPisFqRJR5j6H764aLYD6LWenyvlhnGwGm1WSnWEYCexkLbYwXC3HHkAhbA oOQWU7rCQQbp4j2ktfryEI5ovh/BXNgpxiQwS1+09zF6bEE8dcYtWS3W/1/SPP6/qVAmtZc zHu8iEFWeG9rqrHqNMmFw== X-UI-Out-Filterresults: notjunk:1;V01:K0:7RWiHKWa/wE=:A4rRzY7yoXErHILVmpiCB1 2qY4szm2dSWTctzFAvOaliksjH0PJgcA1vDycf1d/aGVFw9pWkWx2R/VaQpOmzsDX2rWIcswq MvEfejSZ9eZ60FbgBxF8h++C3JlJOJxL4H2OaDI+GG58DEv3afT41GjqaH2P/100cZJTQ9orI UYkNuNr3qJgW1NRAya/gFpSG4A8rLZF4Mf4cowlymfnhXl3LccdG+HyD63H0nR8v7rNLD6eYJ FfZYHefAyoIQqoqmOhaub9gZDT+T4AuD4rH5RUcct+DO0W6450ue+QTfVyWliWkaBtPpSUrEP 3ObELDU/IZPR6TOp+c8GPlECqeqg2GBiUr6zp1MZbQpMbaufwve+3AvNyFIS4KcKvXum/nXYG gnaG/F1wtCy/xiOehENBlyzWrJnTDBeZYnVhoN0GvyfT7MfG7ZhQJwPLjCIqigdjzeBffR2Le Gi7EhnXHTd9y5GITHynDeSYx3i0zaL7VWg5U3kyS0PKQyqgf0a9gtD/a5xMWvIX48HXlDAiZr tXPsybY7HE1RUvLhN1EJEUzHznuoiNffSPQT75HfYbbMjLmYH6Y6YZjH+24f4bPpMwYG+icmu Pob2rXBXOC3e7WSAOvT6R2IUyhyG9k31VCop0H8VL+PbfsfHsQSpSMoNdVYe0xC2HLTY4XgWT +ZCx7LUTGNovC0efdKJl6ta6H2kdMiEiIMrxbMoZqZ6Fc1Vnt1+sFUSfBc+IoKVHNC+cD2C6o mb/d4HMfb7guy/2H Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The push_irq_work_func() function is conditionally defined only when both CONFIG_SMP and HAVE_RT_PUSH_IPI are defined, but the forward declaration remains visibile without HAVE_RT_PUSH_IPI, causing a gcc warning in ARM64 allnoconfig: kernel/sched/rt.c:68:13: warning: 'push_irq_work_func' declared 'static' but never defined [-Wunused-function] This changes the code to use the same condition for both the declaration and the function definition, which gets rid of the warning. As Peter Zijlstra, we can possibly get rid of the whole HAVE_RT_PUSH_IPI thing after: 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking") Until that is done, this patch can be used to avoid the warning. Signed-off-by: Arnd Bergmann Fixes: b6366f048e0c ("sched/rt: Use IPI to trigger RT task push migration instead of pulling") --- Found on arm64 allnoconfig v2: now using #if defined() instead IS_ENABLED() diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index e3cc16312046..ce7b36d6f477 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -64,7 +64,7 @@ static void start_rt_bandwidth(struct rt_bandwidth *rt_b) raw_spin_unlock(&rt_b->rt_runtime_lock); } -#ifdef CONFIG_SMP +#if defined(CONFIG_SMP) && defined(HAVE_RT_PUSH_IPI) static void push_irq_work_func(struct irq_work *work); #endif