From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932370AbbJSNFB (ORCPT ); Mon, 19 Oct 2015 09:05:01 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:59058 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932163AbbJSNE6 (ORCPT ); Mon, 19 Oct 2015 09:04:58 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eric Auger , eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@linaro.org, patches@linaro.org Subject: Re: [PATCH 2/4] vfio: platform: reset: calxedaxgmac: add reset function registration Date: Mon, 19 Oct 2015 15:04:47 +0200 Message-ID: <3829716.dW4OHEgDOa@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445184015-24414-3-git-send-email-eric.auger@linaro.org> References: <1445184015-24414-1-git-send-email-eric.auger@linaro.org> <1445184015-24414-3-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:I6RDRsV8OuvDZe7w1h6zqtC3y6dcNy5wT8PvX+4bg+TCRU9HjYP Uo0pdCUM1yiDhaW4C4/yIAZe99XS6xlcx5M3YHlMF81JJFXw+zZv6SZhEJ6ugGC6V7Q1A2U PN9LU3o3oNMBdeH0VnwtPAlm8vI+zrUxWbvPhkAokC7fzLj9rDX1cpq8onpggGsf3hAbLT8 9bwfLTXtEOEUKghX/KJcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:EDtxiKJz+wA=:PoAEgZOBfaUA0jpkBhtp09 jYdHA9lk8ogD/oy48un878XBBaD5x31yfAmc1kEoK91/d3dxRsHcm56Rfn5Llpy+lUayUhTCY Yo5rNIh3Sg4TM+up0SfL1DksbSyoWjkFV/XL1KK1/RDo7IdgyPmsa8nNVT17nuqho4ajNYmmm RpcMIOPLQTe/fYIf5IdA/cozwKyD8R+y0byJ/+IhvJPl6Vq0b99qtOquEPzWgWERI4+CAvoU7 mLxyu/YPeDm16p2asSbea3M9tIrS6B84+mmGvgEiyPDr8wE5e0ubl/ikxvCMIB9rcXHlBKjSq /XGggnX0ZuBGN+wVbAgVk4HMVbsqMmmC+vUXZD2wK+mx6RFUYnd0qCoL0Xb4wtxVmJZm3rqvY u9mdjggErf9bOTODdNEaVqXb00m4mwI/1ISUSNPhMHnzyRdl7en3wH/vpRrXAbqwT0nDDngOJ +z6uchH3KkDT/Ip3dmGxzZP6/mr4QGg4q0eBpgwFwfzg8VFcLnV7ZLY8Cc8dV0s77HT+25lQc bv/xekC35jsRqMhsS3KRxsu+cOCpnKaSUgZiyzTGI/I4w7yc1UExvkTZJmHdqU9Urf26IJJDG wBCjrVpCwplYujCouZh4hyEAS/aXp5oc9ccY+afEpaDvUSTBFJ7CGLiSLfPuPb4UksHW8igd4 vNro44M5mSxgXyL2HodOD9BzTIFvT4HhHh+aTexFcV5sUEcaVU6ExbjcdIitN2TOKGZYz0z1L 3VHapnIf12Gs/AI8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 18 October 2015 18:00:13 Eric Auger wrote: > diff --git a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c > index 619dc7d..4f76b17 100644 > --- a/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c > +++ b/drivers/vfio/platform/reset/vfio_platform_calxedaxgmac.c > @@ -29,8 +29,7 @@ > #define DRIVER_VERSION "0.1" > #define DRIVER_AUTHOR "Eric Auger " > #define DRIVER_DESC "Reset support for Calxeda xgmac vfio platform device" > - > -#define CALXEDAXGMAC_COMPAT "calxeda,hb-xgmac" > +#define COMPAT "calxeda,hb-xgmac" Why the rename? > /* XGMAC Register definitions */ > #define XGMAC_CONTROL 0x00000000 /* MAC Configuration */ > @@ -80,6 +79,43 @@ int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev) > } > EXPORT_SYMBOL_GPL(vfio_platform_calxedaxgmac_reset); > > +static int __init vfio_platform_calxedaxgmac_init(void) > +{ > + int (*register_reset)(struct module *, char*, > + vfio_platform_reset_fn_t); > + int ret; > + > + register_reset = symbol_get(vfio_platform_register_reset); > + if (!register_reset) > + return -EINVAL; I don't understand what you do the symbol_get() here for. Why not just call that function directly? > + ret = register_reset(THIS_MODULE, COMPAT, > + vfio_platform_calxedaxgmac_reset); This is whitespace damaged, the second line needs to be indented to the opening braces. I would also suggest defining register_reset as a macro that implicitly passes the THIS_MODULE argument, as other subsystems do. Arnd