public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Simon Arlott" <simon@fire.lp0.eu>
To: "Brian Marete" <bgmarete@gmail.com>
Cc: "LKML" <linux-kernel@vger.kernel.org>, linux-dvb@linuxtv.org
Subject: Re: [PATCH] V4L: Link tuner before saa7134
Date: Fri, 18 Jul 2008 12:51:46 +0100	[thread overview]
Message-ID: <38354.simon.1216381906@5ec7c279.invalid> (raw)
In-Reply-To: <6dd519ae0807180428k30abd15eo60fd2856f7a43821@mail.gmail.com>


On Fri, July 18, 2008 12:28, Brian Marete wrote:
> On Jul 14, 6:00 am, hermann pitton <hermann-pit...@arcor.de> wrote:
>>
>> #1 users can't set thetunertype anymore,
>>    but the few cases oftunerdetection from eeprom we have should
>>    work again for that price.
>
> Hello,
>
> Any patch yet for above issue? It seems to have made it into 2.6.26.
>
> I use saa7134 with everything, including the tuner modules, compiled
> as a module. My card is detected as a flyvideo2000. The default tuner
> for that card (#37) allows me to tune into TV but not to FM Radio. I
> can access both functions (TV and FM Radio) if I override with
> tuner=69, which is what I usually do. That override does not work on
> 2.6.26.
>
> Any suggestions?

Modify saa7134_board_init2 so that the manual tuner type setting isn't
ignored. The first thing it does is to overwrite the current value
(set earlier from module parameter) with the static values... even
before trying to autodetect it.

In saa7134-core.c saa7134_initdev:
 dev->tuner_type   = saa7134_boards[dev->board].tuner_type;
+dev->tuner_addr   = saa7134_boards[dev->board].tuner_addr;

In saa7134-cards.c saa7134_board_init2:
-dev->tuner_type   = saa7134_boards[dev->board].tuner_type;
-dev->tuner_addr   = saa7134_boards[dev->board].tuner_addr;

I think that will fix it.

>
> Thanks,
>
> --
> B. Gitonga Marete
> Tel: +254-722-151-590
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
Simon Arlott

  reply	other threads:[~2008-07-18 11:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18 11:28 [PATCH] V4L: Link tuner before saa7134 Brian Marete
2008-07-18 11:51 ` Simon Arlott [this message]
2008-07-18 22:56   ` [linux-dvb] " hermann pitton
2008-07-19  2:16     ` [PATCH] saa7134: Copy tuner data earlier in init to avoid overwriting manual tuner type Simon Arlott
2008-07-21 12:34   ` [PATCH] V4L: Link tuner before saa7134 Brian Marete
  -- strict thread matches above, loose matches on Subject: below --
2008-07-12 18:08 bug: saa7134_init run before v4l2_i2c_drv_init Simon Arlott
2008-07-13  3:20 ` [linux-dvb] " hermann pitton
2008-07-13 18:32   ` [PATCH] V4L: Link tuner before saa7134 Simon Arlott
2008-07-14  2:48     ` hermann pitton
2008-07-14 11:40       ` Simon Arlott
2008-07-15  2:09         ` hermann pitton
2008-07-15 21:40   ` Simon Arlott
2008-07-15 23:12     ` hermann pitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38354.simon.1216381906@5ec7c279.invalid \
    --to=simon@fire.lp0.eu \
    --cc=bgmarete@gmail.com \
    --cc=linux-dvb@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox