From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752203AbcDRUFU (ORCPT ); Mon, 18 Apr 2016 16:05:20 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:54224 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752019AbcDRUFS (ORCPT ); Mon, 18 Apr 2016 16:05:18 -0400 From: Arnd Bergmann To: Pablo Neira Ayuso Cc: Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Daniel Borkmann , Ken-ichirou MATSUZAWA , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code Date: Mon, 18 Apr 2016 22:04:43 +0200 Message-ID: <3838598.xdNY1BW5d9@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160418184336.GA16586@salvia> References: <1460837916-1241019-1-git-send-email-arnd@arndb.de> <4187960.DvZepuNvUx@wuerfel> <20160418184336.GA16586@salvia> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:NbWt4NClc6mbgO7QCcmPtkdGqV/bH7x4AyzwNtT92SLQMRpld3g xxZIFyX1buoru2W8EKNFstYZ9Y54RZqrJYhpNF4STs/OVL3ove2q8NsxaEuvoy5CnJ109IC T/7+tZ7tnJWjpRO3C6KeNkMnnSTuVPim2GsXw1cNyj5awypqQ8uxAvKONivw67qylS+znVK 0ma7BmDfUniVeH38aEeig== X-UI-Out-Filterresults: notjunk:1;V01:K0:s3SbqQilHgg=:43EzbMC8Bf9H9o8Oof2cUK wsrsjtX/dpd4NAxqVWfTD5h2soMTC1uBKYtnPTowt+NjDeCQa50QE7oZPCgzcOHe/PMIl4ugu iXlDAKPX0JjDZtAaG8b7NIY8Bix7qJltQH5N9GBGY6SXJt4QusX1k/pbx1B9/N0R/F4wpPIlE E3/lgsYjBriiuYKzAnqw2HpTO6MgkW32EYboesOQ4SlYC5mw1RQsT9VPQdRPjYgZ8h9RWbUns bIGaH0zEHse5WBPt9N/srxGo831WAVtqaQUCXTM1oDHqtmYDJK25vj8jUGxoRrX0BVm3gJIDQ o4dM5ANuGBKMOzmyYWIzTEydg4nUWML2FRHEwSkLQYqPZXY9GEpD8uwkFW1G/2rEJjSFMkg0I /enqokICr38Udmu2k9eQXaIaINE5hLcugyY8dgvMuVpDAd7Qe9H2Lbc3XbakUrlEe/owhu9Fy RXqYu0a5QnCqcO+eGCXP9LCaPKLLRWGDKz9lZDCHi0xHDJ0LRsdSVpStWJj1nJo3HyUNJ01Sq Ze35yzENglC68/6bSeHc0zVI3LlLYEPtm0CF+5xTVOR5wdzHVGOXkcZS1/Ra3VLFuHWVG728C 9RzG03OZnIbyphP0Vb3pAD/Xd5GM4+9gHKAK951fXHFPzsxdAJITwN/CGYnkcDdQmHT+c4hoQ uuZJh9truyIWkQRmj0XiUnIPjUrbMPqrywCmn5scYJD09Hi7c+Erywxrst+G4zXyyKiyL2P7E zJ6osy1QNjV1zDh1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 18 April 2016 20:43:36 Pablo Neira Ayuso wrote: > On Mon, Apr 18, 2016 at 08:33:15PM +0200, Arnd Bergmann wrote: > > On Monday 18 April 2016 20:16:59 Pablo Neira Ayuso wrote: > > > On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > > > > A recent patch removed many 'inline' annotations for static > > > > functions in this file, which has caused warnings for functions > > > > that are not used in a given configuration, in particular when > > > > CONFIG_NF_CONNTRACK_EVENTS is disabled: > > > > > > > > nf_conntrack_netlink.c:572:15: 'ctnetlink_timestamp_size' defined but not used > > > > nf_conntrack_netlink.c:546:15: 'ctnetlink_acct_size' defined but not used > > > > nf_conntrack_netlink.c:339:12: 'ctnetlink_label_size' defined but not used > > > > > > Arnd, thanks for the fix. > > > > > > I'm planning to push this though: > > > > > > http://patchwork.ozlabs.org/patch/610820/ > > > > > > This is restoring the inlines for the size calculation functions, but > > > I think that's ok. They are rather small and they're called from the > > > event notification path (ie. packet path), so the compiler just place > > > them out of the way when not needed and we calm down the gcc warning. > > > > Looks good. I'll put this in my randconfig builder to replace my own > > patch and will let you know if you missed something. > > Thanks, will wait for your ack then. 100 clean randconfig builds later, looks good to me. Acked-by: Arnd Bergmann