From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/6] compacting file_ra_state
Date: Fri, 20 Jul 2007 19:24:09 +0800 [thread overview]
Message-ID: <384930645.25087@ustc.edu.cn> (raw)
Message-ID: <20070720112409.GB6300@mail.ustc.edu.cn> (raw)
In-Reply-To: <1184928539.20032.171.camel@twins>
On Fri, Jul 20, 2007 at 12:48:59PM +0200, Peter Zijlstra wrote:
> On Fri, 2007-07-20 at 12:26 +0200, Peter Zijlstra wrote:
> > On Fri, 2007-07-20 at 18:07 +0800, Fengguang Wu wrote:
> > > plain text document attachment (short-rasize.patch)
> > > Use 'unsigned int' instead of 'unsigned long' for the readahead indexes/sizes.
> > >
> > > This helps reduce memory consumption on 64bit CPU when
> > > a lot of files are opened.
> > >
> > > Note that the (smaller) 32bit index can support up to 16PB file.
> > > Which should be sufficient large at least for now.
> >
> > Perhaps merge prev_offset and prev_index into a pgoff_t prev? That
> > should give the same savings on 64bit and be more correct on 32bit.
>
> s/pgoff_t/loff_t/
Good idea!
This could solve Andi's concern as well :)
I'm coding it up, and sure it'll need some more tests...
> (and how come lkml was not on the CC list?)
:)
next prev parent reply other threads:[~2007-07-20 11:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070720100740.106917381@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 0/6] readahead cleanups and interleaved readahead Fengguang Wu
[not found] ` <20070720101123.936159499@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 1/6] compacting file_ra_state Fengguang Wu
[not found] ` <p73y7hbux4d.fsf@bingen.suse.de>
[not found] ` <20070720121143.GA8584@mail.ustc.edu.cn>
2007-07-20 12:11 ` Fengguang Wu
2007-07-20 16:02 ` Linus Torvalds
[not found] ` <1184927207.20032.168.camel@twins>
2007-07-20 10:48 ` Peter Zijlstra
[not found] ` <20070720112409.GB6300@mail.ustc.edu.cn>
2007-07-20 11:24 ` Fengguang Wu [this message]
[not found] ` <20070720101124.083676724@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 2/6] mmap read-around simplification Fengguang Wu
[not found] ` <20070720101124.221472134@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 3/6] remove several readahead macros Fengguang Wu
[not found] ` <20070720101124.350754890@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 4/6] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
2007-07-20 11:07 ` Jens Axboe
[not found] ` <20070720112528.GC6300@mail.ustc.edu.cn>
2007-07-20 11:25 ` Fengguang Wu
[not found] ` <20070720101124.470940735@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 5/6] introduce radix_tree_scan_hole() Fengguang Wu
[not found] ` <20070720101124.600141268@mail.ustc.edu.cn>
2007-07-20 10:07 ` [PATCH 6/6] basic support of interleaved reads Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384930645.25087@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox