From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/8] mmap read-around simplification
Date: Sat, 21 Jul 2007 11:57:35 +0800 [thread overview]
Message-ID: <384990324.59504@ustc.edu.cn> (raw)
Message-ID: <20070721035851.185553787@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070721035733.951838089@mail.ustc.edu.cn
[-- Attachment #1: remove-mmap-hit.patch --]
[-- Type: text/plain, Size: 1352 bytes --]
Fold file_ra_state.mmap_hit into file_ra_state.mmap_miss
and make it an int.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
include/linux/fs.h | 3 +--
mm/filemap.c | 4 ++--
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.22-git15.orig/include/linux/fs.h
+++ linux-2.6.22-git15/include/linux/fs.h
@@ -703,8 +703,7 @@ struct file_ra_state {
there are only # of pages ahead */
unsigned int ra_pages; /* Maximum readahead window */
- unsigned long mmap_hit; /* Cache hit stat for mmap accesses */
- unsigned long mmap_miss; /* Cache miss stat for mmap accesses */
+ int mmap_miss; /* Cache miss stat for mmap accesses */
unsigned long prev_index; /* Cache last read() position */
unsigned int prev_offset; /* Offset where last read() ended in a page */
};
--- linux-2.6.22-git15.orig/mm/filemap.c
+++ linux-2.6.22-git15/mm/filemap.c
@@ -1369,7 +1369,7 @@ retry_find:
* Do we miss much more than hit in this file? If so,
* stop bothering with read-ahead. It will only hurt.
*/
- if (ra->mmap_miss > ra->mmap_hit + MMAP_LOTSAMISS)
+ if (ra->mmap_miss > MMAP_LOTSAMISS)
goto no_cached_page;
/*
@@ -1395,7 +1395,7 @@ retry_find:
}
if (!did_readaround)
- ra->mmap_hit++;
+ ra->mmap_miss--;
/*
* We have a locked page in the page cache, now we need to check
--
next prev parent reply other threads:[~2007-07-21 4:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070721035733.951838089@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 0/8] readahead cleanups and interleaved readahead take 2 Fengguang Wu
[not found] ` <20070721035850.977231489@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 1/8] compacting file_ra_state Fengguang Wu
[not found] ` <20070721040644.GA9750@mail.ustc.edu.cn>
2007-07-21 4:06 ` Fengguang Wu
2007-07-21 4:27 ` Linus Torvalds
[not found] ` <20070721042939.GA28875@mail.ustc.edu.cn>
2007-07-21 4:29 ` Fengguang Wu
2007-07-21 5:57 ` Andi Kleen
2007-07-21 6:03 ` Andrew Morton
2007-07-21 6:13 ` Linus Torvalds
2007-07-21 6:17 ` Andi Kleen
[not found] ` <20070721035851.185553787@mail.ustc.edu.cn>
2007-07-21 3:57 ` Fengguang Wu [this message]
[not found] ` <20070721035851.321030363@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 3/8] combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
[not found] ` <20070721035851.461364420@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 4/8] trivial filemap.c cleanups Fengguang Wu
[not found] ` <20070721035851.638623804@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 5/8] remove several readahead macros Fengguang Wu
[not found] ` <20070721035851.791763729@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 6/8] remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
[not found] ` <20070721035851.946351617@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 7/8] introduce radix_tree_scan_hole() Fengguang Wu
[not found] ` <20070721035852.104255316@mail.ustc.edu.cn>
2007-07-21 3:57 ` [PATCH 8/8] basic support of interleaved reads Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384990324.59504@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox