public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>
Subject: [PATCH 1/7] readahead: compacting file_ra_state
Date: Sat, 21 Jul 2007 12:43:01 +0800	[thread overview]
Message-ID: <384993019.16801@ustc.edu.cn> (raw)
Message-ID: <20070721044346.554186594@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070721044300.909424569@mail.ustc.edu.cn

[-- Attachment #1: short-rasize.patch --]
[-- Type: text/plain, Size: 2010 bytes --]

Use 'unsigned int' instead of 'unsigned long' for readahead sizes.

This helps reduce memory consumption on 64bit CPU when
a lot of files are opened.

CC: Andi Kleen <andi@firstfloor.org>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 include/linux/fs.h |    8 ++++----
 mm/filemap.c       |    2 +-
 mm/readahead.c     |    2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

--- linux-2.6.22-rc6-mm1.orig/include/linux/fs.h
+++ linux-2.6.22-rc6-mm1/include/linux/fs.h
@@ -771,12 +771,12 @@ struct fown_struct {
  * Track a single file's readahead state
  */
 struct file_ra_state {
-	pgoff_t start;                  /* where readahead started */
-	unsigned long size;             /* # of readahead pages */
-	unsigned long async_size;       /* do asynchronous readahead when
+	pgoff_t start;			/* where readahead started */
+	unsigned int size;		/* # of readahead pages */
+	unsigned int async_size;	/* do asynchronous readahead when
 					   there are only # of pages ahead */
 
-	unsigned long ra_pages;		/* Maximum readahead window */
+	unsigned int ra_pages;		/* Maximum readahead window */
 	unsigned long mmap_hit;		/* Cache hit stat for mmap accesses */
 	unsigned long mmap_miss;	/* Cache miss stat for mmap accesses */
 	unsigned long prev_index;	/* Cache last read() position */
--- linux-2.6.22-rc6-mm1.orig/mm/filemap.c
+++ linux-2.6.22-rc6-mm1/mm/filemap.c
@@ -840,7 +840,7 @@ static void shrink_readahead_size_eio(st
 	if (count > 5)
 		return;
 	count++;
-	printk(KERN_WARNING "Reducing readahead size to %luK\n",
+	printk(KERN_WARNING "Reducing readahead size to %dK\n",
 		ra->ra_pages << (PAGE_CACHE_SHIFT - 10));
 }
 
--- linux-2.6.22-rc6-mm1.orig/mm/readahead.c
+++ linux-2.6.22-rc6-mm1/mm/readahead.c
@@ -342,7 +342,7 @@ ondemand_readahead(struct address_space 
 		   bool hit_readahead_marker, pgoff_t offset,
 		   unsigned long req_size)
 {
-	unsigned long max;	/* max readahead pages */
+	int max;	/* max readahead pages */
 	int sequential;
 
 	max = ra->ra_pages;

--

  parent reply	other threads:[~2007-07-21  4:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070721044300.909424569@mail.ustc.edu.cn>
2007-07-21  4:43 ` [PATCH 0/7] readahead cleanups and interleaved readahead take 3 Fengguang Wu
     [not found] ` <20070721044346.554186594@mail.ustc.edu.cn>
2007-07-21  4:43   ` Fengguang Wu [this message]
     [not found] ` <20070721044346.687587063@mail.ustc.edu.cn>
2007-07-21  4:43   ` [PATCH 2/7] readahead: mmap read-around simplification Fengguang Wu
     [not found] ` <20070721044346.824927556@mail.ustc.edu.cn>
2007-07-21  4:43   ` [PATCH 3/7] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
     [not found] ` <20070721044347.008643456@mail.ustc.edu.cn>
2007-07-21  4:43   ` [PATCH 4/7] readahead: remove several readahead macros Fengguang Wu
     [not found] ` <20070721044347.111061630@mail.ustc.edu.cn>
2007-07-21  4:43   ` [PATCH 5/7] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
     [not found] ` <20070721044347.250839328@mail.ustc.edu.cn>
2007-07-21  4:43   ` [PATCH 6/7] radixtree: introduce radix_tree_scan_hole() Fengguang Wu
2007-07-21  5:48     ` Andrew Morton
     [not found]       ` <20070721063629.GA7013@mail.ustc.edu.cn>
2007-07-21  6:36         ` Fengguang Wu
2007-07-23  7:58     ` Nick Piggin
     [not found]       ` <20070723080405.GA7420@mail.ustc.edu.cn>
2007-07-23  8:04         ` Fengguang Wu
     [not found]         ` <20070723081209.GA12393@mail.ustc.edu.cn>
2007-07-23  8:12           ` Fengguang Wu
     [not found] ` <20070721044347.388744012@mail.ustc.edu.cn>
2007-07-21  4:43   ` [PATCH 7/7] readahead: basic support of interleaved reads Fengguang Wu
2007-07-21  7:24   ` Rusty Russell
     [not found]     ` <20070721075744.GA10790@mail.ustc.edu.cn>
2007-07-21  7:57       ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=384993019.16801@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox