From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] readahead: remove several readahead macros
Date: Sat, 21 Jul 2007 12:43:04 +0800 [thread overview]
Message-ID: <384993020.10920@ustc.edu.cn> (raw)
Message-ID: <20070721044347.008643456@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070721044300.909424569@mail.ustc.edu.cn
[-- Attachment #1: readahead-macros-cleanup.patch --]
[-- Type: text/plain, Size: 1523 bytes --]
Remove VM_MAX_CACHE_HIT, MAX_RA_PAGES and MIN_RA_PAGES.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
include/linux/mm.h | 2 --
mm/readahead.c | 10 +---------
2 files changed, 1 insertion(+), 11 deletions(-)
--- linux-2.6.22-rc6-mm1.orig/include/linux/mm.h
+++ linux-2.6.22-rc6-mm1/include/linux/mm.h
@@ -1148,8 +1148,6 @@ int write_one_page(struct page *page, in
/* readahead.c */
#define VM_MAX_READAHEAD 128 /* kbytes */
#define VM_MIN_READAHEAD 16 /* kbytes (includes current page) */
-#define VM_MAX_CACHE_HIT 256 /* max pages in a row in cache before
- * turning readahead off */
int do_page_cache_readahead(struct address_space *mapping, struct file *filp,
pgoff_t offset, unsigned long nr_to_read);
--- linux-2.6.22-rc6-mm1.orig/mm/readahead.c
+++ linux-2.6.22-rc6-mm1/mm/readahead.c
@@ -21,16 +21,8 @@ void default_unplug_io_fn(struct backing
}
EXPORT_SYMBOL(default_unplug_io_fn);
-/*
- * Convienent macros for min/max read-ahead pages.
- * Note that MAX_RA_PAGES is rounded down, while MIN_RA_PAGES is rounded up.
- * The latter is necessary for systems with large page size(i.e. 64k).
- */
-#define MAX_RA_PAGES (VM_MAX_READAHEAD*1024 / PAGE_CACHE_SIZE)
-#define MIN_RA_PAGES DIV_ROUND_UP(VM_MIN_READAHEAD*1024, PAGE_CACHE_SIZE)
-
struct backing_dev_info default_backing_dev_info = {
- .ra_pages = MAX_RA_PAGES,
+ .ra_pages = VM_MAX_READAHEAD * 1024 / PAGE_CACHE_SIZE,
.state = 0,
.capabilities = BDI_CAP_MAP_COPY,
.unplug_io_fn = default_unplug_io_fn,
--
next prev parent reply other threads:[~2007-07-21 4:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070721044300.909424569@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 0/7] readahead cleanups and interleaved readahead take 3 Fengguang Wu
[not found] ` <20070721044346.554186594@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 1/7] readahead: compacting file_ra_state Fengguang Wu
[not found] ` <20070721044346.687587063@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 2/7] readahead: mmap read-around simplification Fengguang Wu
[not found] ` <20070721044346.824927556@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 3/7] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
[not found] ` <20070721044347.008643456@mail.ustc.edu.cn>
2007-07-21 4:43 ` Fengguang Wu [this message]
[not found] ` <20070721044347.111061630@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 5/7] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
[not found] ` <20070721044347.250839328@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 6/7] radixtree: introduce radix_tree_scan_hole() Fengguang Wu
2007-07-21 5:48 ` Andrew Morton
[not found] ` <20070721063629.GA7013@mail.ustc.edu.cn>
2007-07-21 6:36 ` Fengguang Wu
2007-07-23 7:58 ` Nick Piggin
[not found] ` <20070723080405.GA7420@mail.ustc.edu.cn>
2007-07-23 8:04 ` Fengguang Wu
[not found] ` <20070723081209.GA12393@mail.ustc.edu.cn>
2007-07-23 8:12 ` Fengguang Wu
[not found] ` <20070721044347.388744012@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 7/7] readahead: basic support of interleaved reads Fengguang Wu
2007-07-21 7:24 ` Rusty Russell
[not found] ` <20070721075744.GA10790@mail.ustc.edu.cn>
2007-07-21 7:57 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384993020.10920@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox