From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <jens.axboe@oracle.com>
Subject: [PATCH 5/7] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb
Date: Sat, 21 Jul 2007 12:43:05 +0800 [thread overview]
Message-ID: <384993020.21779@ustc.edu.cn> (raw)
Message-ID: <20070721044347.111061630@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070721044300.909424569@mail.ustc.edu.cn
[-- Attachment #1: remove-readahead-size-limit.patch --]
[-- Type: text/plain, Size: 1300 bytes --]
Remove the size limit max_sectors_kb imposed on max_readahead_kb.
The size restriction is unreasonable. Especially when max_sectors_kb cannot
grow larger than max_hw_sectors_kb, which can be rather small for some disk
drives.
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
---
block/ll_rw_blk.c | 9 ---------
1 file changed, 9 deletions(-)
--- linux-2.6.22-rc6-mm1.orig/block/ll_rw_blk.c
+++ linux-2.6.22-rc6-mm1/block/ll_rw_blk.c
@@ -3945,7 +3945,6 @@ queue_max_sectors_store(struct request_q
max_hw_sectors_kb = q->max_hw_sectors >> 1,
page_kb = 1 << (PAGE_CACHE_SHIFT - 10);
ssize_t ret = queue_var_store(&max_sectors_kb, page, count);
- int ra_kb;
if (max_sectors_kb > max_hw_sectors_kb || max_sectors_kb < page_kb)
return -EINVAL;
@@ -3954,14 +3953,6 @@ queue_max_sectors_store(struct request_q
* values synchronously:
*/
spin_lock_irq(q->queue_lock);
- /*
- * Trim readahead window as well, if necessary:
- */
- ra_kb = q->backing_dev_info.ra_pages << (PAGE_CACHE_SHIFT - 10);
- if (ra_kb > max_sectors_kb)
- q->backing_dev_info.ra_pages =
- max_sectors_kb >> (PAGE_CACHE_SHIFT - 10);
-
q->max_sectors = max_sectors_kb << 1;
spin_unlock_irq(q->queue_lock);
--
next prev parent reply other threads:[~2007-07-21 4:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070721044300.909424569@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 0/7] readahead cleanups and interleaved readahead take 3 Fengguang Wu
[not found] ` <20070721044346.554186594@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 1/7] readahead: compacting file_ra_state Fengguang Wu
[not found] ` <20070721044346.687587063@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 2/7] readahead: mmap read-around simplification Fengguang Wu
[not found] ` <20070721044346.824927556@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 3/7] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
[not found] ` <20070721044347.008643456@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 4/7] readahead: remove several readahead macros Fengguang Wu
[not found] ` <20070721044347.111061630@mail.ustc.edu.cn>
2007-07-21 4:43 ` Fengguang Wu [this message]
[not found] ` <20070721044347.250839328@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 6/7] radixtree: introduce radix_tree_scan_hole() Fengguang Wu
2007-07-21 5:48 ` Andrew Morton
[not found] ` <20070721063629.GA7013@mail.ustc.edu.cn>
2007-07-21 6:36 ` Fengguang Wu
2007-07-23 7:58 ` Nick Piggin
[not found] ` <20070723080405.GA7420@mail.ustc.edu.cn>
2007-07-23 8:04 ` Fengguang Wu
[not found] ` <20070723081209.GA12393@mail.ustc.edu.cn>
2007-07-23 8:12 ` Fengguang Wu
[not found] ` <20070721044347.388744012@mail.ustc.edu.cn>
2007-07-21 4:43 ` [PATCH 7/7] readahead: basic support of interleaved reads Fengguang Wu
2007-07-21 7:24 ` Rusty Russell
[not found] ` <20070721075744.GA10790@mail.ustc.edu.cn>
2007-07-21 7:57 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=384993020.21779@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox