From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030820AbcCQNyv (ORCPT ); Thu, 17 Mar 2016 09:54:51 -0400 Received: from gloria.sntech.de ([95.129.55.99]:53577 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030679AbcCQNyu convert rfc822-to-8bit (ORCPT ); Thu, 17 Mar 2016 09:54:50 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, patches@linaro.org, lee.jones@linaro.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] ARM: rockchip: Fix use of plain integer as NULL pointer Date: Thu, 17 Mar 2016 14:54:47 +0100 Message-ID: <3852103.Khn1BuqerF@diego> User-Agent: KMail/4.14.10 (Linux/4.2.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1458222191-26023-1-git-send-email-peter.griffin@linaro.org> References: <1458222191-26023-1-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, no need to resend for that (will be lost when applying anyway), but for future patches please consider the things below: Am Donnerstag, 17. März 2016, 13:43:11 schrieb Peter Griffin: > This fixes the following sparse build warning: > > mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer > > Signed-off-by: Peter Griffin please bring aling tags received in previous versions to future ones, like the one from Lee: Acked-by: Lee Jones > --- changes in v2: - beautify commit message otherwise, patch looks nice and I'll pick it up shortly Thanks for catching this Heiko > arch/arm/mach-rockchip/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-rockchip/platsmp.c > b/arch/arm/mach-rockchip/platsmp.c index d42a07e..4d827a0 100644 > --- a/arch/arm/mach-rockchip/platsmp.c > +++ b/arch/arm/mach-rockchip/platsmp.c > @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int > cpu) if (dev) > np = dev->of_node; > else > - np = of_get_cpu_node(cpu, 0); > + np = of_get_cpu_node(cpu, NULL); > > return of_reset_control_get(np, NULL); > }