public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 09/10] filemap: trivial code cleanups
Date: Tue, 24 Jul 2007 10:00:18 +0800	[thread overview]
Message-ID: <385243123.17117@ustc.edu.cn> (raw)
Message-ID: <20070724020043.064974174@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070724020009.677809022@mail.ustc.edu.cn

[-- Attachment #1: cleanup-filemap.patch --]
[-- Type: text/plain, Size: 1453 bytes --]

- remove unused local next_index in do_generic_mapping_read()
- wrap a long line
- remove a redudant page_cache_read() declaration

Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 mm/filemap.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--- linux-2.6.22-rc6-mm1.orig/mm/filemap.c
+++ linux-2.6.22-rc6-mm1/mm/filemap.c
@@ -873,13 +873,11 @@ void do_generic_mapping_read(struct addr
 	unsigned long index;
 	unsigned long offset;
 	unsigned long last_index;
-	unsigned long next_index;
 	unsigned long prev_index;
 	unsigned int prev_offset;
 	int error;
 
 	index = *ppos >> PAGE_CACHE_SHIFT;
-	next_index = index;
 	prev_index = ra->prev_pos >> PAGE_CACHE_SHIFT;
 	prev_offset = ra->prev_pos & (PAGE_CACHE_SIZE-1);
 	last_index = (*ppos + desc->count + PAGE_CACHE_SIZE-1) >> PAGE_CACHE_SHIFT;
@@ -1214,7 +1212,8 @@ out:
 }
 EXPORT_SYMBOL(generic_file_aio_read);
 
-int file_send_actor(read_descriptor_t * desc, struct page *page, unsigned long offset, unsigned long size)
+int file_send_actor(read_descriptor_t * desc, struct page *page,
+			unsigned long offset, unsigned long size)
 {
 	ssize_t written;
 	unsigned long count = desc->count;
@@ -1287,7 +1286,6 @@ asmlinkage ssize_t sys_readahead(int fd,
 }
 
 #ifdef CONFIG_MMU
-static int FASTCALL(page_cache_read(struct file * file, unsigned long offset));
 /**
  * page_cache_read - adds requested page to the page cache if not already there
  * @file:	file to read

--

  parent reply	other threads:[~2007-07-24  2:15 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070724020009.677809022@mail.ustc.edu.cn>
2007-07-24  2:00 ` [PATCH 00/10] readahead cleanups and interleaved readahead take 4 Fengguang Wu
     [not found] ` <20070724020041.774421091@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 01/10] readahead: compacting file_ra_state Fengguang Wu
     [not found] ` <20070724020042.028909529@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 02/10] readahead: mmap read-around simplification Fengguang Wu
     [not found] ` <20070724020042.135275161@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 03/10] readahead: combine file_ra_state.prev_index/prev_offset into prev_pos Fengguang Wu
2007-07-24  3:52     ` Andrew Morton
     [not found]       ` <20070724034801.GA7310@mail.ustc.edu.cn>
2007-07-24  3:48         ` Fengguang Wu
2007-07-24  3:55     ` Andrew Morton
     [not found]       ` <20070724043215.GA6317@mail.ustc.edu.cn>
2007-07-24  4:32         ` Fengguang Wu
2007-07-24  4:53           ` Andrew Morton
     [not found]             ` <20070724062744.GA6686@mail.ustc.edu.cn>
2007-07-24  6:27               ` Fengguang Wu
     [not found]         ` <20070724043708.GA6627@mail.ustc.edu.cn>
2007-07-24  4:37           ` Fengguang Wu
     [not found] ` <20070724020042.319225909@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 04/10] radixtree: introduce radix_tree_scan_hole() Fengguang Wu
     [not found] ` <20070724020042.426486651@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 05/10] readahead: basic support of interleaved reads Fengguang Wu
     [not found] ` <20070724020042.588573597@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 06/10] readahead: remove the local copy of ra in do_generic_mapping_read() Fengguang Wu
     [not found] ` <20070724020042.758542876@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 07/10] readahead: remove several readahead macros Fengguang Wu
     [not found] ` <20070724020042.882116065@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 08/10] readahead: remove the limit max_sectors_kb imposed on max_readahead_kb Fengguang Wu
     [not found] ` <20070724020043.064974174@mail.ustc.edu.cn>
2007-07-24  2:00   ` Fengguang Wu [this message]
     [not found] ` <20070724020043.189132028@mail.ustc.edu.cn>
2007-07-24  2:00   ` [PATCH 10/10] filemap: convert some unsigned long to pgoff_t Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=385243123.17117@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox