From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753944AbcGSPx5 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jul 2016 11:53:57 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:50058 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753197AbcGSPxz (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jul 2016 11:53:55 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: linux-wireless@vger.kernel.org, Kalle Valo <kvalo@codeaurora.org>,
        Larry Finger <Larry.Finger@lwfinger.net>, netdev@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Mateusz Kulikowski <mateusz.kulikowski@gmail.com>,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging/rtl8192e: use s8 instead of char
Date: Tue, 19 Jul 2016 17:53:38 +0200
Message-ID: <3858062.NGQDOLnTj0@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <wrfjy44xvdfn.fsf@redhat.com>
References: <20160719153403.2967812-1-arnd@arndb.de> <20160719153403.2967812-2-arnd@arndb.de> <wrfjy44xvdfn.fsf@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:zwOY4EflghwsFxbJkl+ZMw4Xz3RPi30cpijAW0hbcX6UNb19CZy
 PbmjNTiIe/NcA/JEDXxy0A60SgUT0LB2EYPUVJvZJfz86S6+aovZQnMKGtHmvPecWmT8ERA
 kXVTP+kP7uTqKQhXqzLJBRS5u6jPvfLe4PGolktwZ9pD05ndYG5vzYTyHcEkCJr5RasEzaH
 MSCTdoCAwvzKYxTAHvo0Q==
X-UI-Out-Filterresults: notjunk:1;V01:K0:/2WZ9xwzzq4=:71BWcmlZ80V/8BRZCYjPa0
 qEC24e4JSegDKxUqzLTwNBwB8SeWqj2EG3TZaornT9p4n17YM29Vb+gxBwdXH9HgtDwys3IVe
 Ots2gx8uEYFHvlpcQeS/+zxjkD9gS59XkJI08To16z1y2+g3egwr1RIp5IJ9YDOH0k2v9riL3
 0TMeEPi33RJ1TCbbtUVUz7CkCvtYSip+SQPDb8ktcXYMvfR6REx5dJjZyPL3So4vmHntHJJFf
 8wxKJ06eW58dMwzYPtivBMUpk4nm9tte83UIEx8vo7FrBynBF4JPZwJYd1mp/6xlV+EIK9sVN
 0Lj8acSgYkVFKWbnG9R6PyDUlowFwERR2lYgWY6AcNVOmzms6MR3yjnTBsRoD1Ceo++SWmP5m
 Ym3oRZhIzX7+fkq2ymqFBgbEW7JwKEZS2aQPPjZ+z+8JY7olaVQVSJr5BuQDdQOvrErmOItVG
 kVkWZG87oUv1KLR68d0l1I3uIkC9U8O0eJBpWYyhUvu6cFnqNXyFFGbijwDc7HvdcNt4WcPx8
 Li0Qs2qVRXaSPCRqmlTs9QUdjXjygMI20hR4Cw9uTItVjw0oAPB27tF30fyAUt+TIrqJ6fgyr
 NTrLTbGxWl1JV5739ueD1g1il0MSutQsOyDU5wmxGPy9i1n4Dl6n3UJKYqXBhoCvPACVxtmEO
 37yDd99PM1KMUObmLT5DJokKgYTJI4lJdYuG9LT7IBvZGmFtcbG67bThuCYlZbZS/jzA2BiKL
 1AFWrwAEyFI7OxCp
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, July 19, 2016 11:46:04 AM CEST Jes Sorensen wrote:
> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > index 2c8a526773ed..e0a2fe5e6148 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > @@ -323,7 +323,7 @@ bool GetTs(struct rtllib_device *ieee, struct ts_common_info **ppTS,
> >       if (ieee->current_network.qos_data.supported == 0) {
> >               UP = 0;
> >       } else {
> > -             if (!IsACValid(TID)) {
> > +             if (!IsACValid((s8)TID)) {
> >                       netdev_warn(ieee->dev, "%s(): TID(%d) is not valid\n",
> >                                   __func__, TID);
> >                       return false;
> 
> TID is a 4-bit field, it should never go negative. The cast to s8 seems
> wrong to me, if anything it should be using u8. I do realize the macro
> IsACValid checks against negative too, but that just looks silly to me.

Ok, I'll remove the extra comparison then to avoid the warning:

staging/rtl8192e/rtl819x_TSProc.c:326:14: error: comparison is always true due to limited range of data type [-Werror=type-limits]

I guess it should be a separate patch. I had just stumbled over the
same thing before resending the patch but decided not to change it
to keep the patch simple.

	Arnd