From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D256C433FE for ; Wed, 1 Jun 2022 03:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347860AbiFADfv (ORCPT ); Tue, 31 May 2022 23:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48618 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238155AbiFADfn (ORCPT ); Tue, 31 May 2022 23:35:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 08A079CF64 for ; Tue, 31 May 2022 20:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654054539; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Gh0g9dEVsbyR/6sqN8ICEDn4s73VBSYVoAwroIoGnZU=; b=VU2LgSGyS0cCuFnBHXYD71DqhJvfAWvTBBEkqcPh6flCirufvsyyduy1c+rKF9FDAxVzvs Wud3EshurM8+2x0C8kzz/jFRz7O0shisJFBwqWKBYviAnijWjDm4JihIuNy5Ne07G3Wr/X 14Gv8l34W3wo56wlOMxsk3OljOER/VY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-67-k-s4QdumPBegUQDSGqvETg-1; Tue, 31 May 2022 23:35:30 -0400 X-MC-Unique: k-s4QdumPBegUQDSGqvETg-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC0B029AB414; Wed, 1 Jun 2022 03:35:29 +0000 (UTC) Received: from [10.72.12.91] (ovpn-12-91.pek2.redhat.com [10.72.12.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 59CF5492C3B; Wed, 1 Jun 2022 03:35:23 +0000 (UTC) Reply-To: Gavin Shan Subject: Re: [PATCH v3 09/16] arch_topology: Drop LLC identifier stash from the CPU topology To: Sudeep Holla , linux-kernel@vger.kernel.org Cc: Atish Patra , Atish Patra , Vincent Guittot , Morten Rasmussen , Dietmar Eggemann , Qing Wang , linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, Rob Herring References: <20220525081416.3306043-1-sudeep.holla@arm.com> <20220525081416.3306043-2-sudeep.holla@arm.com> <20220525081416.3306043-3-sudeep.holla@arm.com> <20220525081416.3306043-4-sudeep.holla@arm.com> <20220525081416.3306043-5-sudeep.holla@arm.com> <20220525081416.3306043-6-sudeep.holla@arm.com> <20220525081416.3306043-7-sudeep.holla@arm.com> <20220525081416.3306043-8-sudeep.holla@arm.com> <20220525081416.3306043-9-sudeep.holla@arm.com> <20220525081416.3306043-10-sudeep.holla@arm.com> From: Gavin Shan Message-ID: <3860bfcc-a323-c031-0fdd-77001d338bec@redhat.com> Date: Wed, 1 Jun 2022 11:35:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20220525081416.3306043-10-sudeep.holla@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sudeep, On 5/25/22 4:14 PM, Sudeep Holla wrote: > Since the cacheinfo LLC information is used directly in arch_topology, > there is no need to parse and store the LLC ID information only for > ACPI systems in the CPU topology. > > Remove the redundant LLC ID from the generic CPU arch_topology information. > > Signed-off-by: Sudeep Holla > --- > drivers/base/arch_topology.c | 1 - > include/linux/arch_topology.h | 1 - > 2 files changed, 2 deletions(-) > How about merge the changes to PATCH[08/16]? I don't see why we need put the changes into separate patches. > diff --git a/drivers/base/arch_topology.c b/drivers/base/arch_topology.c > index 4c486e4e6f2f..76c702c217c5 100644 > --- a/drivers/base/arch_topology.c > +++ b/drivers/base/arch_topology.c > @@ -747,7 +747,6 @@ void __init reset_cpu_topology(void) > cpu_topo->core_id = -1; > cpu_topo->cluster_id = -1; > cpu_topo->package_id = -1; > - cpu_topo->llc_id = -1; > > clear_cpu_topology(cpu); > } > diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h > index 58cbe18d825c..a07b510e7dc5 100644 > --- a/include/linux/arch_topology.h > +++ b/include/linux/arch_topology.h > @@ -68,7 +68,6 @@ struct cpu_topology { > int core_id; > int cluster_id; > int package_id; > - int llc_id; > cpumask_t thread_sibling; > cpumask_t core_sibling; > cpumask_t cluster_sibling; > Thanks, Gavin