From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753390AbbJWMfA (ORCPT ); Fri, 23 Oct 2015 08:35:00 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:56083 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbbJWMe5 convert rfc822-to-8bit (ORCPT ); Fri, 23 Oct 2015 08:34:57 -0400 From: Arnd Bergmann To: Pingbo Wen Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH V3] hp_sdc: convert struct timeval to ktime_t Date: Fri, 23 Oct 2015 14:34:52 +0200 Message-ID: <3865085.z48HxzEQ2F@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <6193EA0A-49EB-44FC-950A-F126B855E724@linaro.org> References: <3901659.bcGNtuE6xV@wuerfel> <4634704.Sh0UHGgRyQ@wuerfel> <6193EA0A-49EB-44FC-950A-F126B855E724@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:qoMi4J9jIxUfs3OI29cP51RepnlXgAyH5abCsYO03lhs3v8OsDM j1ywYFHLlzlfc654HBCZKM32p3NxQm2LOczOhsDjABw+ZZfhjAh8udtUYXcGfNnxpJscydT Hlj9Ef41n2+o4ui2Mang8JAb9N48UBAafsGjkYlkp256Qy1lC7bEi6E2pPw3VnCvS3EZPrC fOfxp/feY8+KxSCII5e3w== X-UI-Out-Filterresults: notjunk:1;V01:K0:QA73y9Rt45E=:D3GQN48xkfDOnKHYi85xN1 6Tzaw5rwde0scLy0Wpqh9iuEqbQXJCIvNUO7x9VYjro8VFfLOlgbp9S5htLiMTcXyIP9mnhLV e5a5+6tVWLYvkFh8WIz5ltp96kUaAleruRmlEl2Gq5VSywbiFWjzTORtQimema+lzu9rkNV38 VcyxPIY92Pw3J6H6B73CTXfLr9pL//YbR4gd8r4wjHX0UaMAfWSxzQ62T9JxhLwfFj/7w6CQ4 yvUmnjl6EnmvGkUvA3GDv2cxy7p2xDobbAgZjDg29zJt7KtWZEATOCGCN0Z6kB+Ui9BFZVG0Y 7lLXhiAz16rgbKdYgwPXQm0CG8oqpFNH56eBoSyTq1dwv9er1X2VmmEclpI3Gt1ugFPZyNd9a sSDB1LLyv/r+M3xLpUi6ECI5rsfEtZ26P0FZyTBvszNbIdbTHvqlbAdMZLcwrqiEDJmIjw0kU wSMkp0OUBqazIT3CMURsWDKhN4QBooTEdfEy4pf6McmVLQce9OIEm5K0tVeLauoBYe+IeVlme UQqSi6Bdv/vQpsx3PK7jWIHt3IoLniUEPxvLugaYcXOkijty/2IixIzAcV2dRW5x6ZsB0X07V 04vw1gUq2IQ+bs2Lu0oai8wQzocnJ6wnIdigovceHan28FoKpkczjBEdpO7MuvKBc89XyTkH9 5xFWt9UlOU6v0R+TneLE+Uc9Q3wQS10XjyeM0O11rSkHfNtbs6KcLPs0/WEPV/GG1WSYMwVoV dafRfHdqztNZi7gF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 October 2015 20:19:46 Pingbo Wen wrote: > > > Also, we don't normally have enumerated lists in a changelog, just use > > normal text. The best changelogs typically have three paragraphs: > > > > The first paragraph describes what the driver currently does. For really > > obvious cases, this can be combined with the second paragraph. > > > > The second paragraph explains why that is bad. This is where you can > > mention the monotonic time vs real time issue and say whether we > > just want the timeval removed to fix the kernel in general or whether > > this particular driver is broken. > > > > The third paragraph explains what the patch does to resolve the issue > > described in the second one. This is also where you can list other > > approaches that would have solved the problem, and why you picked on > > over the others. > > Do we really need this in ChangeLog? Commit msg already states this. I think > the purpose of ChangeLog is let people know the main difference of two > version patch at a glance, and the ‘what’ and ‘why’ should be placed in > commit msg. > I was using the terms changelog and commit message interchangeably, sorry for being unclear. I meant the part above the --- line. The revision history you have below the --- line looks good here. Arnd