Re: silly [< >] and other excess

Keith Owens
2000-11-22T22:52:58Z

On Wed, 22 Nov 2000 14:42:05 +0100,
Christian Gennerat <christian.gennerat@vz.cit.alcatel.fr> wrote:
>Andries.Brouwer@cwi.nl a écrit :
>
>> I also left something else
>> that always annoyed me: valuable screen space (on a 24x80 vt)
>> is lost by these silly [< >] around addresses in an Oops.
>> They provide no information at all, but on the other hand
>> cause loss of information because these lines no longer
>> fit in 80 columns causing line wrap and the loss of the
>> top of the Oops.]

You just broke ksymoops. Removing the [< >] is a bad idea, they are
one of the few things that identifies the addresses in the log,
otherwise they just look like hex numbers. ksymoops has to scan log
files which can contain anything and somehow pick out the interesting
lines, you need some identifier on the lines.

>Moreover, there is another problem in Oops:
>the dumped stack is limited to 3 or 4 lines to prevent loss of information
>but the call trace is unlimited and can loose all information,
>and sometimes is printing forever!
>--- arch/i386/kernel/traps.c.orig Mon Oct 2 20:57:01 2000
>+++ arch/i386/kernel/traps.c Sun Nov 5 14:33:52 2000
>@@ -142,11 +142,12 @@
> * out the call path that was taken.
> */
> if (((addr >= (unsigned long) &_stext) &&
>+ (i<32) &&
> (addr <= (unsigned long) &_etext)) ||
> ((addr >= module_start) && (addr <= module_end))) {
> if (i && ((i % 8) == 0))
> printk("\n ");
>- printk("[<%08lx>] ", addr);
>+ printk("%08lx ", addr);
> i++;
> }
> }

There should be no need to restrict the number of lines printed, it is
limited by the top of the kernel stack. If there are more than 32
trace entries on the stack then they should be printed.