public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Matt Mackall <mpm@selenic.com>, John Berthels <jjberthels@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] maps: PSS(proportional set size) accounting in smaps
Date: Fri, 17 Aug 2007 06:05:17 +0800	[thread overview]
Message-ID: <387302129.71819@ustc.edu.cn> (raw)
Message-ID: <20070816220849.064901548@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070816220516.782145952@mail.ustc.edu.cn

[-- Attachment #1: smaps-vmstat.patch --]
[-- Type: text/plain, Size: 3463 bytes --]

The "proportional set size" (PSS) of a process is the count of pages it has in
memory, where each page is divided by the number of processes sharing it. So if
a process has 1000 pages all to itself, and 1000 shared with one other process,
its PSS will be 1500.
               - lwn.net: "ELC: How much memory are applications really using?"

The PSS proposed by Matt Mackall is a very nice metic for measuring an process's
memory footprint. So collect and export it via /proc/<pid>/smaps.

Matt Mackall's pagemap/kpagemap and John Berthels's exmap can also do the job.
They are comprehensive tools. But for PSS, let's do it in the simple way. 


Cc: Matt Mackall <mpm@selenic.com>
Cc: John Berthels <jjberthels@gmail.com>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 fs/proc/task_mmu.c |   29 ++++++++++++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

--- linux-2.6.23-rc2-mm2.orig/fs/proc/task_mmu.c
+++ linux-2.6.23-rc2-mm2/fs/proc/task_mmu.c
@@ -324,6 +324,27 @@ struct mem_size_stats
 	unsigned long private_clean;
 	unsigned long private_dirty;
 	unsigned long referenced;
+
+	/*
+	 * Proportional Set Size(PSS): my share of RSS.
+	 *
+	 * PSS of a process is the count of pages it has in memory, where each
+	 * page is divided by the number of processes sharing it.  So if a
+	 * process has 1000 pages all to itself, and 1000 shared with one other
+	 * process, its PSS will be 1500. (lwn.net)
+	 */
+	u64 	      pss;
+	/*
+	 * To keep (accumulated) division errors low, we adopt 64bit pss and
+	 * use some low bits for division errors. So (pss >> PSS_ERROR_BITS)
+	 * would be the real byte count.
+	 *
+	 * A shift of 12 before division means(assuming 4K page size):
+	 * 	- 1M 3-user-pages add up to 8KB errors;
+	 * 	- supports mapcount up to 2^24, or 16M;
+	 * 	- supports PSS up to 2^52 bytes, or 4PB.
+	 */
+#define PSS_ERROR_BITS	12
 };
 
 struct smaps_arg
@@ -341,6 +362,7 @@ static int smaps_pte_range(pmd_t *pmd, u
 	pte_t *pte, ptent;
 	spinlock_t *ptl;
 	struct page *page;
+	int mapcount;
 
 	pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl);
 	for (; addr != end; pte++, addr += PAGE_SIZE) {
@@ -357,16 +379,19 @@ static int smaps_pte_range(pmd_t *pmd, u
 		/* Accumulate the size in pages that have been accessed. */
 		if (pte_young(ptent) || PageReferenced(page))
 			mss->referenced += PAGE_SIZE;
-		if (page_mapcount(page) >= 2) {
+		mapcount = page_mapcount(page);
+		if (mapcount >= 2) {
 			if (pte_dirty(ptent))
 				mss->shared_dirty += PAGE_SIZE;
 			else
 				mss->shared_clean += PAGE_SIZE;
+			mss->pss += (PAGE_SIZE << PSS_ERROR_BITS) / mapcount;
 		} else {
 			if (pte_dirty(ptent))
 				mss->private_dirty += PAGE_SIZE;
 			else
 				mss->private_clean += PAGE_SIZE;
+			mss->pss += (PAGE_SIZE << PSS_ERROR_BITS);
 		}
 	}
 	pte_unmap_unlock(pte - 1, ptl);
@@ -395,6 +420,7 @@ static int show_smap(struct seq_file *m,
 	seq_printf(m,
 		   "Size:           %8lu kB\n"
 		   "Rss:            %8lu kB\n"
+		   "Pss:            %8lu kB\n"
 		   "Shared_Clean:   %8lu kB\n"
 		   "Shared_Dirty:   %8lu kB\n"
 		   "Private_Clean:  %8lu kB\n"
@@ -402,6 +428,7 @@ static int show_smap(struct seq_file *m,
 		   "Referenced:     %8lu kB\n",
 		   (vma->vm_end - vma->vm_start) >> 10,
 		   sarg.mss.resident >> 10,
+		   (unsigned long)(sarg.mss.pss >> (10 + PSS_ERROR_BITS)),
 		   sarg.mss.shared_clean  >> 10,
 		   sarg.mss.shared_dirty  >> 10,
 		   sarg.mss.private_clean >> 10,

-- 

  parent reply	other threads:[~2007-08-16 22:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070816220516.782145952@mail.ustc.edu.cn>
2007-08-16 22:05 ` [PATCH 0/4] process memory footprints in proc/<pid>/[s|p]maps Fengguang Wu
     [not found] ` <20070816220849.313377588@mail.ustc.edu.cn>
2007-08-16 22:05   ` [PATCH 3/4] maps: introduce generic_maps_open() Fengguang Wu
     [not found] ` <20070816220849.064901548@mail.ustc.edu.cn>
2007-08-16 22:05   ` Fengguang Wu [this message]
2007-08-17  2:13   ` [PATCH 1/4] maps: PSS(proportional set size) accounting in smaps Matt Mackall
     [not found]     ` <20070817024443.GA5521@mail.ustc.edu.cn>
2007-08-17  2:44       ` Fengguang Wu
     [not found] ` <20070816220849.192029043@mail.ustc.edu.cn>
2007-08-16 22:05   ` [PATCH 2/4] maps: address based vma walking Fengguang Wu
2007-08-17  2:16   ` Matt Mackall
     [not found]     ` <20070817025454.GB5521@mail.ustc.edu.cn>
2007-08-17  2:54       ` Fengguang Wu
     [not found] ` <20070816220849.472883642@mail.ustc.edu.cn>
2007-08-16 22:05   ` [PATCH 4/4] maps: /proc/<pid>/pmaps interface - memory maps in granularity of pages Fengguang Wu
2007-08-17  2:38   ` Matt Mackall
     [not found]     ` <20070817034437.GC5521@mail.ustc.edu.cn>
2007-08-17  3:44       ` Fengguang Wu
2007-08-17  3:56       ` Matt Mackall
     [not found]     ` <20070817064727.GA6723@mail.ustc.edu.cn>
2007-08-17  6:47       ` Fengguang Wu
2007-08-17 16:58       ` Matt Mackall
     [not found]         ` <20070818024831.GA7856@mail.ustc.edu.cn>
2007-08-18  2:48           ` Fengguang Wu
2007-08-18  6:40           ` Matt Mackall
     [not found]             ` <20070818103146.GA6744@mail.ustc.edu.cn>
2007-08-18 10:31               ` Fengguang Wu
     [not found]             ` <20070818084531.GB5277@mail.ustc.edu.cn>
2007-08-18  8:45               ` Fengguang Wu
2007-08-18 17:22               ` Matt Mackall
     [not found]                 ` <20070819004008.GA5297@mail.ustc.edu.cn>
2007-08-19  0:40                   ` Fengguang Wu
     [not found] <20070819075410.411207640@mail.ustc.edu.cn>
     [not found] ` <20070819075547.445659254@mail.ustc.edu.cn>
2007-08-19  7:54   ` [PATCH 1/4] maps: PSS(proportional set size) accounting in smaps Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=387302129.71819@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@osdl.org \
    --cc=jjberthels@gmail.com \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox