From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbcBKQMQ (ORCPT ); Thu, 11 Feb 2016 11:12:16 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:64590 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751291AbcBKQMO (ORCPT ); Thu, 11 Feb 2016 11:12:14 -0500 From: Arnd Bergmann To: Paul Gortmaker Cc: Greg Kroah-Hartman , Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 1/6] Revert "drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular" Date: Thu, 11 Feb 2016 17:06:32 +0100 Message-ID: <3873766.I9XIY0R8gT@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20160211160021.GF28452@windriver.com> References: <1455205297-1021302-1-git-send-email-arnd@arndb.de> <1455205297-1021302-2-git-send-email-arnd@arndb.de> <20160211160021.GF28452@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:ZxIR1cMAcMm2JopfevC792ShsBt6QskhkyoCzHWTMGLIDhZoduD v9EYcbA6scngouO6pT1oMfKAl8mb8YjmyPDXQdbh0rNgiVR2OApsWyr1hea1XYmb8z7ND1z mKIbsvRxhPTPuxZahmc3nqq1WtYTticqkyTtOgvlwMye2Zzz7wth27Dh7cEsqzE/s49ibyl Gkjgtk3wO529AyhaZSaZg== X-UI-Out-Filterresults: notjunk:1;V01:K0:vV6OPozNxfU=:hv7/koPeEV1kmT+6OMvw1f z9jgLSreZ509YCS0TpkscLIiIL2dEKTX2s4c5zaCS01H9rG88MwT2Y6Kp19BS1Ae5RMq+PHqG clqp5n8n9AQIO/0xhfbjaEkSoYg7zMBx4N0PNOrUxIWlksdzndqqns50MkG+l52QuxFkCaoa3 vU/TY6/KBo+g09WVNMR1/rFUl5FdeygAuYcTS898zs7bYZymjKZN/YsdC0oYzrHU/OZbGD8pJ QD0BX/cKVKLb6pEAMM7sjLQ25WP1JwF2jOWYEb8XTMje+Rsun50/jiYfsJHkaJJOKtG4EotHx +KuTuhPjYQYNUAHfExozdKDqJYrU8vuGJlLJ0PEt11Z/hDUyGqqo9KcRLsMJu40tRr02SyzyS rvlbniFrBjnUPHruXpxrJiRmc+VVv3EazlUSlpR3V32ADGbDb6bNaWIL9sGku3Cqk92TGYtIw UR4CT8P/X/ZHuS9sRnf9STHpb79Kvb7VSzGRY9sqbxVYoDdzJg3ypftZl18abzim3a0GZIBIE stPN6ueM4a9zdXbLBQCpgyF/86HYV14buKf1yEXSqy0jrGTDPZa43nIznsgr1n6FglKxLE4Si j0WDirM3bt3HyQ15FmU5VpW7Q8KLq+KZzUDo8l2EK393UJ0X2atih7j9XdQ8Hmqx6lhfppAIe Bf1kMdchc0qQZ4XQvV6Fu4oPG7HbnxNzBQ/IMvqyxZXjkRSSha96LnI/uWtgrinxJ5LL8XTM0 TvarY5wZyo7nTFuX Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 11 February 2016 11:00:22 Paul Gortmaker wrote: > [[PATCH v2 1/6] Revert "drivers/tty/serial: make 8250/8250_mtk.c explicitly non-modular"] On 11/02/2016 (Thu 16:41) Arnd Bergmann wrote: > > > This reverts commit d72d391c126e, which tried to remove dead code but > > left the driver in a useless state when the main 8250 driver is a > > Am I misunderstanding something? The commit didn't cause the driver to > be in a useless state for 8250=m. But rather isn't that it was a > pre-existing condition, independent of the change to 8250_mtk.c to > remove the dead code in d72d391c126e? > > Since the commit did not touch Kconfig or Makefile, I can't see how it > could cause some new useless state that did not already exist, and hence > the "Fixes:" tag is invalid as well. My wording may have been bad here. What I meant to say is that it was broken before the patch, and still broken after the patch. The Fixes tag was meant to just be a reference to the commit I'm reverting. Arnd