public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Ken Chen <kenchen@google.com>, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 6/6] prevent time-ordering warnings
Date: Sun, 19 Aug 2007 14:53:55 +0800	[thread overview]
Message-ID: <387507685.32383@ustc.edu.cn> (raw)
Message-ID: <20070819071445.137947640@mail.ustc.edu.cn> (raw)
In-Reply-To: 20070819065349.160284305@mail.ustc.edu.cn

[-- Attachment #1: dirty-order-fix.patch --]
[-- Type: text/plain, Size: 929 bytes --]

It's -mm staff.

Just to make the inode list time ordering check logic comfortable.
Otherwise the old behavior is preferred.

Cc: Ken Chen <kenchen@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
 fs/fs-writeback.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

--- linux-2.6.23-rc2-mm2.orig/fs/fs-writeback.c
+++ linux-2.6.23-rc2-mm2/fs/fs-writeback.c
@@ -224,14 +224,7 @@ static void redirty_tail(struct inode *i
 	struct super_block *sb = inode->i_sb;
 
 	check_dirty_inode(inode);
-	if (!list_empty(&sb->s_dirty)) {
-		struct inode *tail_inode;
-
-		tail_inode = list_entry(sb->s_dirty.next, struct inode, i_list);
-		if (!time_after_eq(inode->dirtied_when,
-				tail_inode->dirtied_when))
-			inode->dirtied_when = jiffies;
-	}
+	inode->dirtied_when = jiffies;
 	list_move(&inode->i_list, &sb->s_dirty);
 	check_dirty_inode(inode);
 }

-- 

      parent reply	other threads:[~2007-08-19  7:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070819065349.160284305@mail.ustc.edu.cn>
2007-08-19  6:53 ` [PATCH 0/6] dirty inode lists time delay/ordering fixes Fengguang Wu
     [not found] ` <20070819071444.499427465@mail.ustc.edu.cn>
2007-08-19  6:53   ` [PATCH 1/6] writeback: fix time ordering of the per superblock inode lists 8 Fengguang Wu
     [not found] ` <20070819071444.629894251@mail.ustc.edu.cn>
2007-08-19  6:53   ` [PATCH 2/6] writeback: fix ntfs with sb_has_dirty_inodes() Fengguang Wu
     [not found] ` <20070819071444.757927082@mail.ustc.edu.cn>
2007-08-19  6:53   ` [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page() Fengguang Wu
     [not found] ` <20070819071444.878093599@mail.ustc.edu.cn>
2007-08-19  6:53   ` [PATCH 4/6] writeback: introduce writeback_control.more_io to indicate more io Fengguang Wu
     [not found] ` <20070819071445.006427549@mail.ustc.edu.cn>
2007-08-19  6:53   ` [PATCH 5/6] check dirty inode list Fengguang Wu
     [not found] ` <20070819071445.137947640@mail.ustc.edu.cn>
2007-08-19  6:53   ` Fengguang Wu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=387507685.32383@ustc.edu.cn \
    --to=wfg@mail.ustc.edu.cn \
    --cc=akpm@linux-foundation.org \
    --cc=akpm@osdl.org \
    --cc=kenchen@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox