From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758458AbcGKKd3 (ORCPT ); Mon, 11 Jul 2016 06:33:29 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:52967 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758348AbcGKKdZ convert rfc822-to-8bit (ORCPT ); Mon, 11 Jul 2016 06:33:25 -0400 From: Arnd Bergmann To: Wan ZongShun Cc: Wan Zongshun , linux-arm-kernel , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Jason Cooper , Daniel Lezcano , linux-kernel , p.zabel@pengutronix.de, Thomas Gleixner Subject: Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900 Date: Mon, 11 Jul 2016 12:36:16 +0200 Message-ID: <3879062.QodNaKgPKS@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1606219.BzcByuFgJm@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:AIaCfWSiFgxobSFZ0roNfdQ5y5uwrxQlnzEUq0LV0zxkj/FcMYA 7gE1CLJrDvQ+z+9B2XLFb91mDt++4qv2xhyGj2INDh8/abLkjSiqchIEODv6d2ax1rPdgty W8qjHAZMQ4rBthNNtc3DBzEpIDqXo0pefCvUYEui/9oHRp5pjgZ2BXmJtkHCqsEdbldBDP8 RAQReiVVRDUpqeRr6vU2g== X-UI-Out-Filterresults: notjunk:1;V01:K0:OHDUkzVZ4WY=:hgseFWltHOJgk8hKZcePm1 WLB24U5aw+fP27stfWkRRh4irCB9if4WwmSXxeJbiO+a8rBpDLvKAdXEqg4H5CBqs6MnhuOnx ZDtt7xJZ3ZPNhfQ3cBzVYJgXyYaHRFpGObQzsJwNm1syNK3JkeVHsaL/Y1RYcZJxiwWkbPlI0 uWvpKWwd5Zr6hL19E2VgCWRTp5hOaArvTBYRDpJ34L2HHFi7B2FlLaHaeXE1HQ85WiNSiq3nT DHHCKfi7dzm3XOuOS2DIo3VAt0j8kMpPonuXiR1hGweFSeo4S5vrOGQ3I/ZC3H4+PJXIxukkD lNJhEK8m2dikf3SAku1v8Prvyj4VhMGt0YAExPQ0rEfTa8gjMbjFX4Qxdgke+8J4l4LpmniHD 6W9YYRHsvicz2qbPgmLU5jsstuAewVBYTQ3N+IzwHjBEca83GLyk6SeWYxOVABfw3maFgjJr8 yJr/hyjI7jt0kTR8oPiZg87Lcr32yOxXa2IRqpWSGSJQ0Myq+PmfJYmjcvx3S8b/sT07onWbv e2HZRnwZ2EIFIgG9nnAQlIxGzziLrdMyUPqtZuGlo+SKrR4W3VFXmvdIyHC1uJ2Av1/ZTeDDx xI1NZlnRtzblr6BVCXGfqfrbjyYyA0RKxWpv/MKjj1SMY4CdYOtTnzbZhTyk+hFjV6RkdKUox J4vU6u5W8PY3eRqvshafIaEj/xG/J+5OdDw4hGsdbG4QxfbaoFZ/622eEzKzDG1w+pQXsvRla iHXxZuc3iKkyKwBC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 11, 2016 6:28:57 PM CEST Wan ZongShun wrote: > 2016-07-11 18:24 GMT+08:00 Arnd Bergmann : > > On Monday, July 11, 2016 5:07:01 PM CEST Wan Zongshun wrote: > >> > >> On 2016年07月11日 16:03, Arnd Bergmann wrote: > >> > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > >> >> + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id); > >> >> + if (ret) > >> >> return -EINVAL; > >> >> + > >> >> + soc_dev_attr->machine = "NUC900EVB"; > >> >> + soc_dev_attr->family = "NUC900"; > >> >> + soc_dev = soc_device_register(soc_dev_attr); > >> >> + if (IS_ERR(soc_dev)) { > >> >> + kfree(soc_dev_attr); > >> >> + return -ENODEV; > >> >> + } > >> >> + > >> >> + ret = regmap_read(syscon_regmap, GCR_CHIPID, &nuc900_chipid); > >> >> + if (ret) > >> >> + return -ENODEV; > >> >> + > >> >> + device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); > >> >> + device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); > >> >> + > >> >> + dev_info(&pdev->dev, "Nuvoton Chip ID: 0x%x, Version ID:0x%x\n", > >> >> + nuc900_chipid & GCR_CHIPID_MASK, > >> >> + (nuc900_chipid >> 24) & 0xff); > >> > > >> > I'm still a bit unsure about the set of attributes here. > >> > > >> > - The "soc_id" is read from the device tree from the field that contains > >> > the board name, I think for consistency you should try to map the > >> > GCR_CHIPID to the name of the SoC and assign that here > >> > >> I will try to get chipid and map it to soc name like: “nuc970”, "nuc910". > >> > >> And I will set this soc name to soc_id, ok? > > > > Ok. > > Maybe I also can set versionid as soc name partly, like > nuc970-version1,nuc970-version2? and then set the to soc_id, make > sense? > I didn't exactly understand what the suggestion is, maybe send that as code so I see what you mean. Arnd