Re: [PATCH v1 1/1] ASoC: cs35l56: Drop malformed default N from Kconfig

[Richard Fitzgerald <rf@opensource.cirrus.com>]

On 13/05/2026 5:26 pm, Andy Shevchenko wrote:
> First of all, it has to be 'default n' (small letter n), otherwise
> it looks for CONFIG_N which is absent and in case of appearance
> will enable something unrelated. Second and most important is that
> 'n' *is* the default 'default' already. Hence just drop malformed
> line.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   sound/soc/codecs/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 069ec05e4a61..db321b9f6771 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -900,7 +900,6 @@ menu "CS35L56 driver options"
>   
>   config SND_SOC_CS35L56_CAL_DEBUGFS
>   	bool "CS35L56 create debugfs for factory calibration"
> -	default N
>   	depends on DEBUG_FS
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help
> @@ -911,7 +910,6 @@ config SND_SOC_CS35L56_CAL_DEBUGFS
>   
>   config SND_SOC_CS35L56_CAL_SET_CTRL
>   	bool "CS35L56 ALSA control to restore factory calibration"
> -	default N
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help
>   	  Allow restoring factory calibration data through an ALSA
> @@ -925,7 +923,6 @@ config SND_SOC_CS35L56_CAL_SET_CTRL
>   
>   config SND_SOC_CS35L56_CAL_PERFORM_CTRL
>   	bool "CS35L56 ALSA control to perform factory calibration"
> -	default N
>   	select SND_SOC_CS35L56_CAL_DEBUGFS_COMMON
>   	help
>   	  Allow performing factory calibration data through an ALSA

Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>