From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D3C93ACA41 for ; Wed, 8 Jul 2026 07:53:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783497250; cv=none; b=HyJ7TpQ833QPENNDB69jeKaIQ4u8w7AJ1f2gRf6JmPbADnE4V77wvVpRzRmGvc6RHTE7P3eRdsQvpBaotmSqdEJontMx+dxQiDVY+2Pemkdx4wt2n0JaSFeqC4614BG4uozIkuxT3cJllrlMCfA+y2BcN286gQtVstsQAvlo0eY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783497250; c=relaxed/simple; bh=xLHBOj7fSqS5CuVp17POylN/kJtmwNDKxNmNnT7C1wo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FToM7PThsCyuoJBEOFP6axzSUrC360JWFuukBmtGEkw6jky0x598LHlb7eFrpUsMVp2eEfy1RnrqBAZRq+oZ4sBO3ZXUXz1aPSO4+avj/mlgUheCbSq7wmoNzhQJcgHvDAVsB2okWVdTPq0X/nm5eyOdWvydCB2y6Zw8nBbGjfA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PSXkx+AD; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PSXkx+AD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E00D1F00A3A; Wed, 8 Jul 2026 07:53:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783497230; bh=Kz17m858MwgmWF0pwgeoxvWnX7L23Knguhas3J0CszA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=PSXkx+ADZfW3APdL8Mcv3m10d6qta0/K0OCwLF8sTK6GVdKLsDTDR9oB7raWgQ0zs BC34mH5WyyCkbdi0QS63qH82iF1si5BWu1ADcxa/rr/62PEx0+qm5nVLUzSk12Ck/1 mA5Woi6fdPI2b/DDfuP0elY1sY1UxwCG1Prid+/m8fDrMas+hiSsOJkAqD99N6yN3P Uy8es6zRdjoVIsq5u0tK8FpQYs5DkeJScw8GFAodtHmnmR3tnqVNj0HnuJAkX+7guQ /PVD7RV6x9KllwmT6DTcdtkilMZMB5a6RblqzK6MM13EwVn11Gqe0ZC3hoY5DFfWDo N67YHdLZs2nwg== Message-ID: <38ad90d8-0887-4cb9-b874-53ce35b6dbfe@kernel.org> Date: Wed, 8 Jul 2026 09:53:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/ksm: Initialize the addr only once in collect_procs_ksm To: xu.xin16@zte.com.cn, akpm@linux-foundation.org, chengming.zhou@linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <202607081219094603lvrfl0HWd-31cAGrp79l@zte.com.cn> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <202607081219094603lvrfl0HWd-31cAGrp79l@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/8/26 06:19, xu.xin16@zte.com.cn wrote: > From: xu xin > > Similar with 318d87b8fa7 ("ksm: initialize the addr only once in rmap_walk_ksm"), checkpatch.pl should complain here "Similar as commit 318d87b8fa7 ("ksm: initialize the addr only once in rmap_walk_ksm")," ... > Only initialize the addr only once in rmap_walk_ksm because the addr variable s/Only/only/, but you une one "only" too much here. > doesn't change across iterations. > > Signed-off-by: Xu Xin > --- > mm/ksm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index c1dcc3cb4831..337eb04a9340 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -3289,7 +3289,7 @@ void collect_procs_ksm(const struct folio *folio, const struct page *page, > rcu_read_lock(); > for_each_process(tsk) { > struct anon_vma_chain *vmac; > - unsigned long addr; > + const unsigned long addr = rmap_item->address & PAGE_MASK; > struct task_struct *t = > task_early_kill(tsk, force_early); > if (!t) > @@ -3299,7 +3299,6 @@ void collect_procs_ksm(const struct folio *folio, const struct page *page, > { > vma = vmac->vma; > if (vma->vm_mm == t->mm) { > - addr = rmap_item->address & PAGE_MASK; > add_to_kill_ksm(t, page, vma, to_kill, > addr); > } -- Cheers, David