From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50C8E7E0E8 for ; Mon, 19 Jan 2026 14:44:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833842; cv=none; b=OOBVs1FJxUXFlQobrZWDO1KiuA/WkeoudDaDs1rwMwu1jThIfleKjbXZscVi8CkETDyLBAeOIon0OSgJ83TT8poS8qmoHaySWTpW5KG8Y6wJiuWs9Tha/w8yF1KqXyDI7BdVaStD7oumHtZfYZVvJXv///7tCj7SuYogirVwMuA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768833842; c=relaxed/simple; bh=dtj1A8eUfZ/xb7svK+I33mpWY7sLUFcIA2x81DomNdA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KyC1yeB6cxRmDcq9j3/DJ7zObEqg9F6hkadhRDjznyiIEVtnRXyOzsvo8xSmWK8nrlsKnAvdx8geggSDQPVwe7zZJP8jnuimmubT86eO0RdKnvlvL4eGEgvY3Cri94K5hAtCr+d25KKemlDGzGmkwkSJ4fmwRFnxTbNMuX3cbJg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f0zD3sAL; arc=none smtp.client-ip=209.85.167.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f0zD3sAL" Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-59b9fee27ccso454500e87.2 for ; Mon, 19 Jan 2026 06:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768833839; x=1769438639; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Hw8g4FncQCT0qG+FJkoHCdORpG7mMrMlB+H9ZegPebQ=; b=f0zD3sALxsbBPb8f+a7zJeRhH91ZNkc2pIhX82Uf7Jatdf6NAH6wKHOLXtVnXUWino /CgdqqcZpg90Hx87Nq+5thWEjXG1dmGnqhtkp9OL1bx2Cq8QMFpZLQb16GkXBqV7pXga CfKEvnQdHq03l7Arydo26WofbMDpchcx8a/4bXwIdk+HKr9FXniOxnJUoCnbx+u5NPN6 hj/fVzVIXe5hcDkRQ6gE/T0hfRN+VSHJ+RdBbPcz5BeU3Yxt/5kjNkuW6euipNp8hDLa bLY4A23TyA7568uHx7ekXWkdMiNMP0X+feJWJYwOF/yftgFizLZh9jc7pNoAJUFkP7QJ 2IwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768833839; x=1769438639; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Hw8g4FncQCT0qG+FJkoHCdORpG7mMrMlB+H9ZegPebQ=; b=fA2G6kZw+bBCfFGMEEWMqxy8H1JI+NMhoS/9/SDNOwV/zFqgAckMJqPAeTqIrBG2rd Xe1YE5E78QeZa6bYO/cSAlUQ6Z049dI1yqTr+FLI1Gyyjl9edXNzG/FKVibMuqLvoctU 4Gc995QjNsiDlG2eicflAwCnp30Bl/AgvDZLt1HlxgbDpYFrotdBV+LYMFjQXbFl4V9d lFQokkh+sHV1QlO1PenAYs5oFrQW9roETlC7YiaXoNMCRZL/Cuw1RIvlnGltwxAyngCz 04ycAB6FHoKA4i8s2bDPfvnOQk0tgiw4gBiovs+HVfto1nZzbwNzfao9F1dGZ2dg3BOc ectA== X-Forwarded-Encrypted: i=1; AJvYcCWB1x4ETArvHZQp7E7tKc13dmMvliFiLeltLfrD5bVamzk8KDZf0bkKFFuIFX7PN8WLTvuq5JDUyd/ZKG8=@vger.kernel.org X-Gm-Message-State: AOJu0YxVSPHdSHofH49+UJ4j/a3SBh/GB2rKUbhhvxHDtD8axMPRnHbt TrgX7SFDQ4cF6k6hxUwTTPkqX0nsvlFYmBAJb8/cdR3x4xJKbCreJLsy X-Gm-Gg: AY/fxX7ga/iBh8tsWDRdEJmvc0rnjVybiw6pPyEzvosAVUjXpJNzkIBd7zhxRLPal0F CwS6xglx/0yyhuS+OQZ0eaMsJg6HGBUBNRtS8fwLRIIkJXEfVcE595UhUZJ6VX+D93iI3Mo1KVe zBcq8/j3GBHlyl0dzmDKMYqBy1RWYGz90yXdtzRqAI7ZlwYIJsxxR/pxUI1PWCFpzJJGNbFEuDM NVSykgrxQoBKZiHy5DjhCiWPGAfte46S6vKVZ/I8x24s/kW2Q2X17z+rDLe6ESBf+F6ihIhZUg4 IPgymoHx4dwGcSX2jXp0YPlO0TdW/xTCMNMqrDv+ILXut6XfkAOxrrrRlpdRl1fXhnnoJA1yrpU CSv3iA1X1Sz0g1fCfvj7/g29dhOWWeH0ac92ws89R7Jyd0J+ROHPuOVBf0XAq2ZZgXA3iE3Ad8k tYcBdsr3to29m160/1O6goVEj13uMd X-Received: by 2002:ac2:4f14:0:b0:597:d7a1:aa9c with SMTP id 2adb3069b0e04-59baeefe804mr2049768e87.3.1768833839215; Mon, 19 Jan 2026 06:43:59 -0800 (PST) Received: from [10.214.35.248] ([80.93.240.68]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-59baf3a1746sm3435146e87.91.2026.01.19.06.43.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jan 2026 06:43:58 -0800 (PST) Message-ID: <38bcbe9c-5bc6-4bfa-b4ed-e187e048d600@gmail.com> Date: Mon, 19 Jan 2026 15:43:02 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/kasan: Fix KASAN poisoning in vrealloc() To: Andrew Morton , Andrey Konovalov Cc: =?UTF-8?Q?Maciej_=C5=BBenczykowski?= , Maciej Wieczor-Retman , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, Uladzislau Rezki , linux-kernel@vger.kernel.org, linux-mm@kvack.org, joonki.min@samsung-slsi.corp-partner.google.com, stable@vger.kernel.org References: <20260113191516.31015-1-ryabinin.a.a@gmail.com> <10812bb1-58c3-45c9-bae4-428ce2d8effd@gmail.com> <20260118164812.411f8f4f76e3a8aeec5d4704@linux-foundation.org> Content-Language: en-US From: Andrey Ryabinin In-Reply-To: <20260118164812.411f8f4f76e3a8aeec5d4704@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 1/19/26 1:48 AM, Andrew Morton wrote: > On Sat, 17 Jan 2026 18:08:36 +0100 Andrey Konovalov wrote: > >> On Sat, Jan 17, 2026 at 2:16 AM Andrey Konovalov wrote: >>> >>> On Fri, Jan 16, 2026 at 2:26 PM Andrey Ryabinin wrote: >>>> >>>> So something like bellow I guess. >>> >>> Yeah, looks good. >>> >>>> I think this would actually have the opposite effect and make the code harder to follow. >>>> Introducing an extra wrapper adds another layer of indirection and more boilerplate, which >>>> makes the control flow less obvious and the code harder to navigate and grep. >>>> >>>> And what's the benefit here? I don't clearly see it. >>> >>> One functional benefit is when HW_TAGS mode enabled in .config but >>> disabled via command-line, we avoid a function call into KASAN >>> runtime. >> >> Ah, and I just realized than kasan_vrealloc should go into common.c - >> we also need it for HW_TAGS. > > I think I'll send this cc:stable bugfix upstream as-is. > Please, include follow-up fix before sending. We have to move kasan_vrealloc() to common.c as shadow.c is not compiled for CONFIG_KASAN_HW_TAGS=y. So without the fixup, CONFIG_KASAN_HW_TAGS=y will become broken.