Re: [PATCH v2 1/1] remoteproc: Add support for xo clock

Bjorn Andersson
2016-11-01T17:46:28Z

On Tue, Nov 1, 2016 at 10:41 AM, Stephen Boyd <sboyd@codeaurora.org> wrote:
> On 10/31/2016 05:05 PM, Bjorn Andersson wrote:
>> On Tue 25 Oct 13:57 PDT 2016, Sarangdhar Joshi wrote:
>>
>>> Add xo clock support required to boot up Qualcomm ADSP processor.
>>> The ADSP remoteproc driver keeps xo clock enabled until the
>>> driver receives "handover" irq, in order to allow ADSP processor
>>> to vote for xo clock with rpm.
>> Looks good, thanks.
>>
>> We have to add the clock to the DT binding and run that by Rob again,
>> before merging the driver and this patch.
>>
>
> Maybe we should make the xo clock required. We always have a clock for
> it somewhere, either RPM controlled or as a fixed rate clock so it
> should work just as well.
>

As far as I can see it is required, after Sarangdhar's patch - so this
is what I meant we need to add to the DT binding before merging that.
And as you say, we can always make it reference "xo_board" for now.

Regards,
Bjorn