Re: [PATCH V2 2/4] misc: vop: do not allocate and reassign the used ring

Christoph Hellwig
2020-09-29T10:24:28Z

> diff --git a/include/uapi/linux/mic_common.h b/include/uapi/linux/mic_common.h
> index 504e523f702c..e680fe27af69 100644
> --- a/include/uapi/linux/mic_common.h
> +++ b/include/uapi/linux/mic_common.h
> @@ -56,8 +56,6 @@ struct mic_device_desc {
> * @vdev_reset: Set to 1 by guest to indicate virtio device has been reset.
> * @guest_ack: Set to 1 by guest to ack a command.
> * @host_ack: Set to 1 by host to ack a command.
> - * @used_address_updated: Set to 1 by guest when the used address should be
> - * updated.
> * @c2h_vdev_db: The doorbell number to be used by guest. Set by host.
> * @h2c_vdev_db: The doorbell number to be used by host. Set by guest.
> */
> @@ -67,7 +65,6 @@ struct mic_device_ctrl {
> __u8 vdev_reset;
> __u8 guest_ack;
> __u8 host_ack;
> - __u8 used_address_updated;
> __s8 c2h_vdev_db;
> __s8 h2c_vdev_db;
> } __attribute__ ((aligned(8)));

This is an ABI change.