From: Dipen Patel <dipenp@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Yang Yingliang <yangyingliang@huawei.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hte: tegra: fix 'struct of_device_id' build error
Date: Thu, 15 Dec 2022 15:30:21 -0800 [thread overview]
Message-ID: <38f2d681-80a8-dc97-e5ed-4886e5e3bf7c@nvidia.com> (raw)
In-Reply-To: <20221215164626.1209452-1-arnd@kernel.org>
On 12/15/22 8:46 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without the extra #include, this driver produces a build failure
> in some configurations.
>
> drivers/hte/hte-tegra194-test.c:96:34: error: array type has incomplete element type 'struct of_device_id'
> 96 | static const struct of_device_id tegra_hte_test_of_match[] = {
>
> Fixes: 9a75a7cd03c9 ("hte: Add Tegra HTE test driver")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/hte/hte-tegra194-test.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
> index 5d776a185bd6..ce8c44e79221 100644
> --- a/drivers/hte/hte-tegra194-test.c
> +++ b/drivers/hte/hte-tegra194-test.c
> @@ -6,6 +6,7 @@
> */
>
> #include <linux/err.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/moduleparam.h>
> #include <linux/interrupt.h>
I will push this change from HTE tree. Thanks.
Acked-by: Dipen Patel <dipenp@nvidia.com>
prev parent reply other threads:[~2022-12-15 23:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 16:46 [PATCH] hte: tegra: fix 'struct of_device_id' build error Arnd Bergmann
2022-12-15 23:30 ` Dipen Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38f2d681-80a8-dc97-e5ed-4886e5e3bf7c@nvidia.com \
--to=dipenp@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox