From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163147AbdAIQMX (ORCPT ); Mon, 9 Jan 2017 11:12:23 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:59426 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757765AbdAIQLT (ORCPT ); Mon, 9 Jan 2017 11:11:19 -0500 X-AuditID: b6c32a2e-f79f46d000002a13-a7-5873b623398a From: Bartlomiej Zolnierkiewicz To: Geert Uytterhoeven Cc: Tejun Heo , Michael Schmitz , "linux-ide@vger.kernel.org" , linux-m68k , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/3] ata: add m68k/Atari Falcon PATA support Date: Mon, 09 Jan 2017 17:11:12 +0100 Message-id: <3908219.8toGAOhnv9@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42LZdlhTU1dlW3GEQedWZotnt/YyWRzb8YjJ 4vKuOWwWy5+sZbaY2zqd3eLX8qOMDmweO2fdZffYtKqTzePQ4Q5Gj5Ot31g8Pm+SC2CN4rJJ Sc3JLEst0rdL4Mr4+uImW0EjX8WJC+vYGxibubsYOTkkBEwkHn1cxw5hi0lcuLeerYuRi0NI YCmjxNJLB1ghnHYmieb7L4AcDrCOH//NQBqEBJYzSuycZQhR85VR4uWmbWwgCTYBK4mJ7asY QepFBHQl5vxkAqlhFvjIKHFhVyNYjbCAg0TXnV5GEJtFQFVi+uITYHFeAU2JvVO/gtmiAl4S W/a1M4HM4RQIljizPBWiRFDix+R7LCA2s4C8xL79U1khbB2Js8fWMYLskhBYxC7xoecfI8TN shKbDjBDPOki8ePZHDYIW1ji1fEtUM9LS/xdeosRwp7OKLH9twTEnM2MEqt2T4AqspY4fPwi 1DI+id7fT5gg5vNKdLQJQZR4SJzsPgVV7iix+PZadkj4PGKUWNz3kWUCo/wsJD/MQvLDLCQ/ LGBkXsUollpQnJueWmxaYKxXnJhbXJqXrpecn7uJEZxGtPR2MP5b4H2IUYCDUYmHd8Ok4ggh 1sSy4srcQ4wSHMxKIrzqG4FCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeRdUWEcICaQnlqRmp6YW pBbBZJk4OKUaGDdPluDbzXSs6FVJW8Hqpq4n338yeWxyu+k9J8bz3BsL08x9d99ceb9j5Qd5 XXaBgJqI6ytnixude2DDyF3SdYFjT2mOuffDzw0FzU5Xosxe/Tt/+sJ0SaHYM8mGq2bU5ypb FKXtyU5z4F2788bsG+lZBmxq0h/ESpz26O84dHJFpL2pYFO1rhJLcUaioRZzUXEiAJ4laNkf AwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t9jAV2lbcURBu+bTSye3drLZHFsxyMm i8u75rBZLH+yltlibut0dotfy48yOrB57Jx1l91j06pONo9DhzsYPU62fmPx+LxJLoA1ys0m IzUxJbVIITUvOT8lMy/dVik0xE3XQkkhLzE31VYpQtc3JEhJoSwxpxTIMzJAAw7OAe7BSvp2 CW4ZX1/cZCto5Ks4cWEdewNjM3cXIweHhICJxI//Zl2MnECmmMSFe+vZuhi5OIQEljJKvGh/ xwKSEBL4yijRsFUNxGYTsJKY2L6KEaRXREBXYs5PJpB6ZoGPjBK3p11gBKkRFnCQ6LrTC2az CKhKTF98gg3E5hXQlNg79SuYLSrgJbFlXzsTiM0pECwx60Iv1OInjBJtEyYxQzQISvyYfA/s CGYBeYl9+6eyQthaEut3HmeawCgwC0nZLCRls5CULWBkXsUokVqQXFCclJ5rlJdarlecmFtc mpeul5yfu4kRHFnPpHcwHt7lfohRgINRiYc3YkJxhBBrYllxZe4hRgkOZiURXvWNQCHelMTK qtSi/Pii0pzU4kOMpkAfTmSWEk3OB0Z9Xkm8oYm5ibmxgYW5paWJkZI4b+PsZ+FCAumJJanZ qakFqUUwfUwcnFINjBxFN5/+UJgtZrwu+37v4bbn59taFotODRYPSjepfeKmx9wTKaMu0bqk d5PyNl0bzYyNSnKT62tf1jgti81YMyk0c4l53BlRl+csFxYfTzt2If4ic76JV6xztvKOUwvN G9OusL/x5pnubb9W6YHl1o7Q7SIm21OaGVtm+Al/vqCZMpnbZOMRJZbijERDLeai4kQA2CHZ WsICAAA= X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170109161114epcas5p30bcfafb0deddcfbfe3ba2ac3e41a0359 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20161230140139epcas5p160eda5a6a77be084e21f12002c85cc2a X-RootMTR: 20161230140139epcas5p160eda5a6a77be084e21f12002c85cc2a References: <1483106478-1382-1-git-send-email-b.zolnierkie@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, January 03, 2017 11:49:16 AM Geert Uytterhoeven wrote: > Hi Bartlomiej, > > On Fri, Dec 30, 2016 at 3:01 PM, Bartlomiej Zolnierkiewicz > wrote: > > This patchset adds m68k/Atari Falcon PATA support to libata. > > Thanks for your series! > > That leaves us with 4 to go ;-) > > CONFIG_BLK_DEV_GAYLE > CONFIG_BLK_DEV_BUDDHA > CONFIG_BLK_DEV_MAC_IDE > CONFIG_BLK_DEV_Q40IDE They should be easy to port to libata, one just needs to remember to use ->qc_defer for ports that require serialization. > Note that using libata instead of the legacy IDE driver increases kernel size. > > After enabling libata: > > CONFIG_ATA=y > CONFIG_ATA_VERBOSE_ERROR=y > CONFIG_ATA_SFF=y > CONFIG_PATA_FALCON=y > > an atari_defconfig kernel grew by: > > add/remove: 775/0 grow/shrink: 753/41 up/down: 98999/-242 (98757) > > After disabling CONFIG_IDE: > > add/remove: 0/589 grow/shrink: 0/12 up/down: 0/-62835 (-62835) > > So the net result is: > > add/remove: 775/589 grow/shrink: 749/51 up/down: 98886/-62964 (35922) SATA-specific code is not needed on legacy PATA systems so it should be possible to reduce the size by adding new config option (i.e. SATA_HOST) and: - covering SATA only code with CONFIG_SATA_HOST ifdefs - making SATA_HOST to be selected by SATA host drivers in drivers/ata/KConfig > Disabling CONFIG_ATA_VERBOSE_ERROR saved 1380 bytes, which is less than the > value advertised by Kconfig (6KB). If it is only ~1kB nowadays I would vote for making the error logging always verbose and just removing CONFIG_ATA_VERBOSE_ERROR, Tejun? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics