From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Rik van Riel <riel@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick Piggin <nickpiggin@yahoo.com.au>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Kumar Gala <galak@kernel.crashing.org>,
Pete Zaitcev <zaitcev@redhat.com>, Greg KH <greg@kroah.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout()
Date: Fri, 28 Sep 2007 09:18:46 +0800 [thread overview]
Message-ID: <390942329.08474@ustc.edu.cn> (raw)
Message-ID: <20070928011846.GA5496@mail.ustc.edu.cn> (raw)
In-Reply-To: <20070927111610.68584fdd@bree.surriel.com>
On Thu, Sep 27, 2007 at 11:16:10AM -0400, Rik van Riel wrote:
> On Thu, 27 Sep 2007 09:50:16 +0800
> Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
>
> > We don't want to introduce pointless delays in throttle_vm_writeout()
> > when the writeback limits are not yet exceeded, do we?
>
> Good catch.
Thank you.
> > Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
>
> Reviewed-by: Rik van Riel <riel@redhat.com>
It could be a good fix for 2.6.22/23. But for -mm, I'm not
sure if throttle_vm_writeout() will be eventually removed ;-)
next prev parent reply other threads:[~2007-09-28 1:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070927015016.GA11080@mail.ustc.edu.cn>
2007-09-27 1:50 ` [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout() Fengguang Wu
2007-09-27 15:16 ` Rik van Riel
[not found] ` <20070928011846.GA5496@mail.ustc.edu.cn>
2007-09-28 1:18 ` Fengguang Wu [this message]
2007-09-27 20:47 ` Andrew Morton
2007-09-28 8:02 ` Ingo Molnar
2007-09-27 22:59 ` Nick Piggin
2007-09-28 16:23 ` Mathieu Desnoyers
2007-09-28 0:10 ` Nick Piggin
2007-09-28 17:57 ` Mathieu Desnoyers
2007-09-28 19:50 ` Frank Ch. Eigler
2007-09-28 20:25 ` Nick Piggin
2007-09-27 21:49 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=390942329.08474@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@linux-foundation.org \
--cc=galak@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=riel@redhat.com \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox